Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent rmarkdown::run from failing when file is NULL and dir is set #1703

Merged
merged 3 commits into from Nov 22, 2019

Conversation

@jenzopr
Copy link
Contributor

jenzopr commented Nov 21, 2019

Hi Yihui,

I prefixed all occurrences of default_file with values from dir in case it was NULL. This allows the user to give a full path for default_file as well.

Xref: #1700

Best,
Jens

jenzopr and others added 3 commits Nov 21, 2019
@yihui
yihui approved these changes Nov 22, 2019
Copy link
Member

yihui left a comment

Thank you!

@yihui yihui merged commit 5bb98e1 into rstudio:master Nov 22, 2019
1 check was pending
1 check was pending
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@jenzopr

This comment has been minimized.

Copy link
Contributor Author

jenzopr commented Nov 25, 2019

Thank you for the fast reply 👍

yihui added a commit that referenced this pull request Dec 4, 2019
…ULL and dir is set (#1703)"

This reverts commit 5bb98e1 and fixes #1714 by creating the correct `target_file`.
@yihui

This comment has been minimized.

Copy link
Member

yihui commented Dec 4, 2019

FYI I just reverted this PR because of #1714 and used the alternative fix you mentioned in #1700. Thanks again!

@jenzopr

This comment has been minimized.

Copy link
Contributor Author

jenzopr commented Dec 4, 2019

Oh, my bad then! Thanks for the note.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.