Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mark_utf8 should set encoding to the name of lists #841

Merged
merged 2 commits into from Oct 19, 2016
Merged

Conversation

@shrektan
Copy link
Contributor

shrektan commented Oct 19, 2016

or when read the yaml files, the Chinese var names display messes still.

@shrektan shrektan force-pushed the shrektan:patch-1 branch from 0a49e49 to 17cd225 Oct 19, 2016
@shrektan shrektan force-pushed the shrektan:patch-1 branch from 17cd225 to 986d777 Oct 19, 2016
@jjallaire

This comment has been minimized.

Copy link
Member

jjallaire commented Oct 19, 2016

@yihui I'll let you review and merge this one since you are the foremost export on UTF-8!

@shrektan Could you add an item to inst/NEWS for this fix?

@shrektan

This comment has been minimized.

Copy link
Contributor Author

shrektan commented Oct 19, 2016

@jjallaire added.

@yihui Actually, I find this issue when I use your code in bookdown for reading utf-8 yaml files...

@yihui yihui merged commit d3b8406 into rstudio:master Oct 19, 2016
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@yihui

This comment has been minimized.

Copy link
Member

yihui commented Oct 19, 2016

@shrektan Great. Thanks a lot! Actually are you familiar with C? I really hope someone can fix the root problem in the yaml package instead of patching it over and over again.

@shrektan

This comment has been minimized.

Copy link
Contributor Author

shrektan commented Oct 20, 2016

@yihui unfortunately I'm not~

@yihui

This comment has been minimized.

Copy link
Member

yihui commented Oct 20, 2016

@shrektan That is fine. I have found a C expert and will try his solution.

@shrektan shrektan deleted the shrektan:patch-1 branch Oct 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.