Revert "distinguish command-click from other gestures that cause go t…

…o function definition"

This reverts commit caf5233.

src/gwt/src/org/rstudio/studio/client/workbench/views/console/shell/assist/CompletionManager.java

@@ -24,8 +24,6 @@ interface InitCompletionFilter
       boolean shouldComplete(NativeEvent keyDownEvent) ;
    }
 
-   void commandClick();
-
    void goToFunctionDefinition();
 
    void close();

src/gwt/src/org/rstudio/studio/client/workbench/views/console/shell/assist/NullCompletionManager.java

@@ -20,10 +20,6 @@ public void close()
    {
    }
 
-   public void commandClick()
-   {
-   }
-
    public void goToFunctionDefinition()
    {
    }

src/gwt/src/org/rstudio/studio/client/workbench/views/console/shell/assist/RCompletionManager.java

@@ -149,11 +149,6 @@ public void close()
       popup_.hide();
    }
 
-   public void commandClick()
-   {
-      goToFunctionDefinition()
-;   }
-
    public void goToFunctionDefinition()
    {   
       // determine current line and cursor position

src/gwt/src/org/rstudio/studio/client/workbench/views/source/editors/codebrowser/CodeBrowserEditingTargetWidget.java

@@ -133,12 +133,6 @@ else if (event.getKeyCode() == 113) // F2
             return false;
          }
 
-         @Override
-         public void commandClick()
-         {
-            goToFunctionDefinition();
-         }
-
          @Override
          public void goToFunctionDefinition()
          {

src/gwt/src/org/rstudio/studio/client/workbench/views/source/editors/text/AceEditor.java

@@ -258,8 +258,8 @@ public void onClick(AceClickEvent event)
                // set the cursor position
                setCursorPosition(event.getDocumentPosition());
 
-               // notify completion manager of a command click
-               completionManager_.commandClick();
+               // go to function definition
+               completionManager_.goToFunctionDefinition();
             }
          }
       });