Skip to content
Browse files

Fix tabstop wrapping in preferences dialogs when section selection ch…


- Fixes #5573
- When a control with a roving tabstop is first or last in a modal dialog,
  it must notify the dialog when the selection moves to or from the first
  or last tab, otherwise the tab wrapping is broken
  • Loading branch information
gtritchie committed Oct 17, 2019
1 parent 1df15c7 commit 9a0ef5102f83f4366166210df07ba07d839f2fc4
Showing with 6 additions and 0 deletions.
  1. +6 −0 src/gwt/src/org/rstudio/core/client/prefs/
@@ -92,6 +92,12 @@ protected PreferencesDialogBase(String caption,
Integer index = selectionEvent.getSelectedItem();

// SectionChooser is first focusable control in the modal dialog, and it
// uses a roving tabindex to determine the focused section tab, so notify dialog
// when focus leaves or arrives at first tab
if ((currentIndex_ != null && currentIndex_ == 0) || index == 0)

if (currentIndex_ != null)
setPaneVisibility(panes_[currentIndex_], false);

0 comments on commit 9a0ef51

Please sign in to comment.
You can’t perform that action at this time.