132c90da4a
Commits on Jun 23, 2022
Commits on Jun 22, 2022
-
a number of fixes / tweaks to the diagnostics system (#11454)
* [WIP] * [WIP] * improve handling of glue expressions * handle errors when finding method * further refine glue handling * allow parsing of formulas in 'case' calls * improve handling of glue open, close * remove debugging * further refine * handle embedded strings * tweak * fixups * use debug messages * don't allow advancing onto null terminator * update NEWS
-
tweaks to discovery of open ports for desktop (#11475)
* tweaks to discovery of open ports for desktop * logging tweaks * PR feedback * use winsock when checking for available port * unix impl * missing headers for unix * tweak comment * other cleanups
-
Merge pull request #11473 from rstudio/sw-news-issue-refs
Add missing issue references
-
Merge pull request #11472 from rstudio/feature/remove-libedit2-pkg-dep
Remove the redundant libedit2 dependency for Debian packages
-
Merge pull request #11469 from rstudio/bugfix/single-session-resume
Fix problems with list() method and single-session mode resume
-
-
Merge pull request #11467 from rstudio/feature/deprecate-qt-builds
stop building Qt desktop
-
-
-
Remove the redundant libedit2 dependency for Debian packages.
This was originally added in 2e7e7ab to support the bundled libclang (since libedit is a dependency of LLVM). However, since 543edee we depend on the system libclang-dev on Debian-based distros, which was part of the move away from using the bundled libclang on Linux (#2892). Since libedit2 is a dependency of libclang-dev on all supported Debian-based distros, we can safely remove this explicit dependency. To verify that libedit2 is a transitive dependency of libclang-dev, you can check the following: $ apt-cache depends --installed --recurse -i libclang-dev | \ grep 'Depends: libedit2' Signed-off-by: Aaron Jacobs <aaron.jacobs@rstudio.com>
-
-
Fix problems with list() method and single-session mode resume
** Note - requires a companion commit in pro to add the new validate parameter to list() in a few places. Let me do the merge so I can coordinate. When initializing an rsession without a specific session id, if there is more than one rsession, use the most recent one rather than creating a new one each time. If an extra session gets left over, that will never resolve itself until all sessions are cleared.
-
Merge pull request #11468 from rstudio/feature/remove-libapparmor-pkg…
…-dep Remove the unused libapparmor1 dependency for Debian-based distros
Commits on Jun 21, 2022
-
-
Merge pull request #11465 from rstudio/bugfix/deprecate-tools-shell-c…
…ommand deprecate the Tools / Shell command
-
Remove the unused libapparmor1 dependency for Debian-based distros.
AppArmor functionality was removed in e939585 as part of the work to create Launcher in 2018, but it looks like the Debian package dependency was never removed. Signed-off-by: Aaron Jacobs <aaron.jacobs@rstudio.com>
-
-
Merge pull request #11463 from rstudio/feature/electron-19-0-5
update to Electron 19.0.5
-
-
Merge pull request #11441 from rstudio/bugfix/remove-unused-urlopener
stop building unused urlopener for Electron
-
For non-launcher sessions, need to pass the server rpc key
Initialize the socket rpc before the session scope is initialized in the options so the initial "validate" works. We already pass the server's rpc secret key for OS/Server since it's in the server's environment and the fork/exec inherits it but we don't for non-launcher sessions so this adds that.
-
Merge pull request #11460 from rstudio/bugfix/session-rpc-non-launcher
For non-launcher sessions, need to pass the server rpc key
-
For non-launcher sessions, need to pass the server rpc key
Initialize the socket rpc before the session scope is initialized in the options so the initial "validate" works. We already pass the server's rpc secret key for OS/Server since it's in the server's environment and the fork/exec inherits it but we don't for non-launcher sessions so this adds that.
Commits on Jun 20, 2022
-
-
Fixes a few db/rpc session problems found in testing
- don't ensureDirectory for scratch path in ActiveSession since that code runs on the server scratchPath is not accessible. This is already done by the File storage implementation when it's required and so is not necessary here. - Similarly don't check for scratchPath existing in ActiveSession::validate since that check is in file storage.isValid called by empty() - Similarly for ActiveSessions and rootStoragePath - fixes for editor/workbench renaming, consistently map and unmap columnName/propertyName for each property in the list - diagnostics for destroySession when row does not exist - don't suppress errors for "session doesn't exist" in read-property RPC - treat "session not found" as a special error in read property. This is only a partial fix to the fact that readProperty() will return a default value if either the session does not exist, the rpc fails, or some other error. That's not a great development pattern so I'll file an issue to fix this and improve the performance by batching 'read property' calls and caching them on the client. Not really a problem for rsession but causes a ton of extra rpc calls in rsession and poor error checking (i.e. might return a default property value when the rpc fails in a ton of code paths). - add some missing apis for db queries (that were made in pro only but seem to compile in OS so why not?)
-
Merge pull request #11459 from rstudio/bugfix/db-tests-editor-prop
Fix editor property/workbench column mismatch causing tests to fail