3ce52b8d00
Commits on Jun 23, 2022
Commits on Jun 22, 2022
-
tweaks to discovery of open ports for desktop (#11475)
* tweaks to discovery of open ports for desktop * logging tweaks * PR feedback * use winsock when checking for available port * unix impl * missing headers for unix * tweak comment * other cleanups
-
Merge pull request #11473 from rstudio/sw-news-issue-refs
Add missing issue references
-
-
Commits on Jun 21, 2022
-
For non-launcher sessions, need to pass the server rpc key
Initialize the socket rpc before the session scope is initialized in the options so the initial "validate" works. We already pass the server's rpc secret key for OS/Server since it's in the server's environment and the fork/exec inherits it but we don't for non-launcher sessions so this adds that.
Commits on Jun 20, 2022
-
-
Fixes a few db/rpc session problems found in testing
- don't ensureDirectory for scratch path in ActiveSession since that code runs on the server scratchPath is not accessible. This is already done by the File storage implementation when it's required and so is not necessary here. - Similarly don't check for scratchPath existing in ActiveSession::validate since that check is in file storage.isValid called by empty() - Similarly for ActiveSessions and rootStoragePath - fixes for editor/workbench renaming, consistently map and unmap columnName/propertyName for each property in the list - diagnostics for destroySession when row does not exist - don't suppress errors for "session doesn't exist" in read-property RPC - treat "session not found" as a special error in read property. This is only a partial fix to the fact that readProperty() will return a default value if either the session does not exist, the rpc fails, or some other error. That's not a great development pattern so I'll file an issue to fix this and improve the performance by batching 'read property' calls and caching them on the client. Not really a problem for rsession but causes a ton of extra rpc calls in rsession and poor error checking (i.e. might return a default property value when the rpc fails in a ton of code paths). - add some missing apis for db queries (that were made in pro only but seem to compile in OS so why not?)
Commits on Jun 18, 2022
Commits on Jun 17, 2022
-
Merge pull request #11437 from rstudio/bugfix/return-count-db-query
Fix bug with counting sessions
-
Merge pull request #11440 from rstudio/bugfix/update-uid-on-cookie
Fix a bug with upgrading to SW and using DB session storage
Commits on Jun 16, 2022
-
add title label to help info popup (#11442)
* add title label to help info popup * <a> also in black in help info popup
-
-
Commits on Jun 15, 2022
-
-
Merge pull request #11431 from rstudio/bugfix/electron-clipboard-issu…
…e-linux Fixed issue that was breaking clipboard on Electron for Linux
-
-
-
-
-
Merge pull request #11433 from rstudio/bugfix/windows-rpc-build-fails
Fix windows builds after Session Metadata changes
-
-
Commits on Jun 14, 2022
-
Merge pull request #11419 from rstudio/feature/session-init-dbg-log
Add 'starting' debug log right after log is initialized
-
Merge pull request #11430 from rstudio/bugfix/find_in_files_crash_bad…
…_regex Prevent crashes with malformed regex which match all lines of content
-
-
-
-
-