Skip to content
Permalink
Tree: 9a7b3ea53c
Commits on Feb 4, 2020
  1. Merge pull request #6143 from rstudio/feature/renv-install-dependencies

    kevinushey committed Feb 4, 2020
    install dependencies with renv::install() in renv projects
  2. Merge pull request #6154 from rstudio/feature/inc-to-pbc

    jmcphers committed Feb 4, 2020
    Bulk update RStudio, Inc => RStudio, PBC
  3. Merge pull request #6148 from rstudio/bugfix/dark-mode-job-status-con…

    gtritchie committed Feb 4, 2020
    …trast
    
    fix color of job status in dark mode
  4. correct some shortcuts in static reference page

    gtritchie committed Feb 4, 2020
  5. fix color of job status in dark mode

    gtritchie committed Feb 4, 2020
    - Use the normal text color instead of a hardcoded color
    - Fixes #6144
  6. Merge pull request #6133 from rstudio/feature/keyboard-shortcut-helper

    gtritchie committed Feb 4, 2020
    utility command to help search for available keyboard shortcuts
  7. tweaks based on PR feedback

    gtritchie committed Feb 4, 2020
    - instead of using a checkbox menu-item to toggle on/off, closing the messagebar will exit this mode
    - show a message when shortcut resolution still pending (e.g. multi-gesture shortcuts)
    - cleanup ShowWarningBarEvent to use our single-file model instead of separate Event, Handler, Data source files
Commits on Feb 3, 2020
  1. update NEWS re: default tab wrap

    jmcphers committed Feb 3, 2020
  2. Merge pull request #6139 from rstudio/feature/default-tab-wrap

    jmcphers committed Feb 3, 2020
    Wrap around editor tabs by default
  3. wrap around tabs by default

    jmcphers committed Feb 3, 2020
Commits on Feb 1, 2020
  1. fix typo

    gtritchie committed Feb 1, 2020
  2. utility command to help search for available keyboard shortcuts

    gtritchie committed Feb 1, 2020
    - Toggle via Help / Diagnostics / Short Keyboard Shortcut Command
    - When on, a message bar is shown at bottom of main window, and any shortcuts typed will report their bound command (or "Shortcut not bound") but not fire the command
    - Shows mappings even if command is currently disabled
    - Could be the basis of a "real" feature (what does this shortcut do), and as a bonus it will read the results via screen reader due to message bar being a live region, but for now just considering a dev tool
    - Doesn't account for platform differences (Windows vs Mac vs Linux, desktop vs browser), so there are some edge cases you won't catch unless you try on all those, or at least double-check in commands.cmd.xml
    - When you turn off this mode, it hides the warning bar for you
Commits on Jan 31, 2020
  1. Merge pull request #6100 from rstudio/bugfix/shared-core-bugs

    MariaSemple committed Jan 31, 2020
    Fix some shared_core bugs and comments
Commits on Jan 30, 2020
  1. Merge pull request #6126 from rstudio/bugfix/update-shortcuts-page

    gtritchie committed Jan 30, 2020
    tweaks to keyboard shortcuts page
  2. Merge pull request #6124 from rstudio/bugfix/keyboard-shortcut-help-s…

    gtritchie committed Jan 30, 2020
    …creenreader
    
    Show accessible keyboard shortcut help when screenreader enabled
  3. use characters instead of entities for Mac keyboard symbols

    gtritchie committed Jan 30, 2020
    Much easier to read the source. Also put the Mac shortcuts in the standard order (Ctrl+Opt+Shift+Cmd+Foo).
  4. fix boost version in readme (1.63 -> 1.69)

    MariaSemple committed Jan 30, 2020
  5. show standalone keyboard shortcuts help page when screenreader enabled

    gtritchie committed Jan 30, 2020
    - Fixes #6118
    - Also emit an announcement if user brings up the VIM help pane (:help in editor) warning that VIM help isn't screen reader accessible, will open a separate issue on making VIM help accessible (don't consider a high priority)
    - Not impossible to make the popup panel accessible, but not trivial, either; needs to do the things a modal dialog does (make rest of UI inert, provide a way to close with keyboard and mouse that isn't simply "click anywhere, type anything", then ensure the content of the panel is reasonably accessible)
  6. Merge pull request #6120 from rstudio/bugfix/a11y-keyboard-shortcut-s…

    gtritchie committed Jan 30, 2020
    …tatic-page
    
    Improve screen reader accessibility of "All Keyboard Shortcuts" page
  7. correct offset of shiny background job URL

    jmcphers committed Jan 30, 2020
  8. Improve screen reader accessibility of "All Keyboard Shortcuts" page

    gtritchie committed Jan 30, 2020
    - use separate tables (with headings) for each section, instead of one table with headings inside the table
    - allows screen readers to see individually named tables
    - properly associate headings with columns so screen readers can announce
    - tweaked visual formatting so all the tables have same column widths (got that for free with single table)
    - switch Mac shortcuts to use Mac Unicode characters (these are supported by VoiceOver on Mac, and we use them on our automatically generated shortcuts overlay)
    - still need to review for missing/changed shortcuts, will do that after this
Commits on Jan 29, 2020
  1. Merge pull request #6119 from rstudio/bugfix/unstomp-build-keyboard-s…

    gtritchie committed Jan 29, 2020
    …hortcut
    
    fix broken "build" keyboard shortcut
  2. fix broken "build" keyboard shortcut

    gtritchie committed Jan 29, 2020
    I broke this when I added Ctrl+Shift+B as shortcut for reading editor info via screen reader; I checked for that shortcut existing at Ctrl+Shift+B but I didn't look for Cmd+Shift+B (which ends up being the same thing on Windows).
    
    Changed the accessibility shortcut to Ctrl+Alt+Shift+B. Also changed "toggleScreenReader" to Ctrl+Alt+Shift+/ for consistency.
    
    Added a group for accessibility shortcuts and put them on the shortcuts reference popup.
    
    Noticed and fixed incorrect shortcuts for terminal next/prev in the static keyboard.htm page, and logged an issue #6117 to work on making that page be automatically generated (or at least update it manually) for 1.3.
    
    Fixes #6115
  3. Blacklist for Typo.js unsupported dictionaries (#6109)

    adamconroy committed Jan 29, 2020
    * add blacklist for typo.js unsupported dictionaries
    
    * realtime spellchecking blacklist PR feedback tweaks
  4. Merge pull request #6114 from rstudio/bugfix/console-color-255-bleed

    gtritchie committed Jan 29, 2020
    fix resetting of ANSI console color 255 (foreground or background)
  5. fix resetting of ANSI console color 255 (foreground or background)

    gtritchie committed Jan 29, 2020
    - simple edge-case bug
Older
You can’t perform that action at this time.