Skip to content
Permalink
Tree: b488dab23a
Commits on Jan 30, 2020
  1. Merge pull request #6126 from rstudio/bugfix/update-shortcuts-page

    gtritchie committed Jan 30, 2020
    tweaks to keyboard shortcuts page
  2. Merge pull request #6124 from rstudio/bugfix/keyboard-shortcut-help-s…

    gtritchie committed Jan 30, 2020
    …creenreader
    
    Show accessible keyboard shortcut help when screenreader enabled
  3. use characters instead of entities for Mac keyboard symbols

    gtritchie committed Jan 30, 2020
    Much easier to read the source. Also put the Mac shortcuts in the standard order (Ctrl+Opt+Shift+Cmd+Foo).
  4. fix boost version in readme (1.63 -> 1.69)

    MariaSemple committed Jan 30, 2020
  5. show standalone keyboard shortcuts help page when screenreader enabled

    gtritchie committed Jan 30, 2020
    - Fixes #6118
    - Also emit an announcement if user brings up the VIM help pane (:help in editor) warning that VIM help isn't screen reader accessible, will open a separate issue on making VIM help accessible (don't consider a high priority)
    - Not impossible to make the popup panel accessible, but not trivial, either; needs to do the things a modal dialog does (make rest of UI inert, provide a way to close with keyboard and mouse that isn't simply "click anywhere, type anything", then ensure the content of the panel is reasonably accessible)
  6. Merge pull request #6120 from rstudio/bugfix/a11y-keyboard-shortcut-s…

    gtritchie committed Jan 30, 2020
    …tatic-page
    
    Improve screen reader accessibility of "All Keyboard Shortcuts" page
  7. correct offset of shiny background job URL

    jmcphers committed Jan 30, 2020
  8. Improve screen reader accessibility of "All Keyboard Shortcuts" page

    gtritchie committed Jan 30, 2020
    - use separate tables (with headings) for each section, instead of one table with headings inside the table
    - allows screen readers to see individually named tables
    - properly associate headings with columns so screen readers can announce
    - tweaked visual formatting so all the tables have same column widths (got that for free with single table)
    - switch Mac shortcuts to use Mac Unicode characters (these are supported by VoiceOver on Mac, and we use them on our automatically generated shortcuts overlay)
    - still need to review for missing/changed shortcuts, will do that after this
Commits on Jan 29, 2020
  1. Merge pull request #6119 from rstudio/bugfix/unstomp-build-keyboard-s…

    gtritchie committed Jan 29, 2020
    …hortcut
    
    fix broken "build" keyboard shortcut
  2. fix broken "build" keyboard shortcut

    gtritchie committed Jan 29, 2020
    I broke this when I added Ctrl+Shift+B as shortcut for reading editor info via screen reader; I checked for that shortcut existing at Ctrl+Shift+B but I didn't look for Cmd+Shift+B (which ends up being the same thing on Windows).
    
    Changed the accessibility shortcut to Ctrl+Alt+Shift+B. Also changed "toggleScreenReader" to Ctrl+Alt+Shift+/ for consistency.
    
    Added a group for accessibility shortcuts and put them on the shortcuts reference popup.
    
    Noticed and fixed incorrect shortcuts for terminal next/prev in the static keyboard.htm page, and logged an issue #6117 to work on making that page be automatically generated (or at least update it manually) for 1.3.
    
    Fixes #6115
  3. Blacklist for Typo.js unsupported dictionaries (#6109)

    adamconroy committed Jan 29, 2020
    * add blacklist for typo.js unsupported dictionaries
    
    * realtime spellchecking blacklist PR feedback tweaks
  4. Merge pull request #6114 from rstudio/bugfix/console-color-255-bleed

    gtritchie committed Jan 29, 2020
    fix resetting of ANSI console color 255 (foreground or background)
  5. fix resetting of ANSI console color 255 (foreground or background)

    gtritchie committed Jan 29, 2020
    - simple edge-case bug
  6. add helper methods to virtual console unit tests

    gtritchie committed Jan 29, 2020
  7. improve organization of NEWS

    jmcphers committed Jan 29, 2020
  8. remove outdated reference to AppArmor; fixes #6110

    jmcphers committed Jan 29, 2020
  9. Merge pull request #6108 from rstudio/feature/help-keyboard-shortcuts

    gtritchie committed Jan 29, 2020
    add keyboard shortcuts for next/previous help page, and for searching R Help
Commits on Jan 28, 2020
  1. add keyboard shortcuts for next/previous help page, and for searching…

    gtritchie committed Jan 28, 2020
    … R help
    
    - Fixes #5149
    - Also added "Search R Help" command to Help menu; shows Help pane if not visible and puts focus in the search field
    - Shortcut for "Search R Help" is Ctrl+Alt+F1 (editable as "Help Search" command)
    - Shortcut for previous help page is Alt+Shift+F2 (editable as "Help Back" command)
    - Shortcut for next help page is Alt+Shift+F3 (editable as "Help Forward" command)
    - Added missing menu accelerator and trailing "..." to Manage License command (Desktop Pro)
  2. Merge pull request #6107 from rstudio/bugfix/menubutton-state

    gtritchie committed Jan 28, 2020
    ensure menu buttons have correct expanded state after menu closes
  3. ensure menu buttons have correct expanded state after menu closes

    gtritchie committed Jan 28, 2020
    - Fixes #6106
    - Also follow best-practice from Aria guidelines and remove aria-expanded altogether when the menu is closed, instead of setting it to false (otherwise screen readers may read some additional and not-helpful information when buttons get focus)
    - Some duplicate code due to two similar implementation of toolbar menu buttons; consolidating this is a future chore
  4. Merge pull request #6102 from rstudio/bugfix/keyboard-support-help-sl…

    gtritchie committed Jan 28, 2020
    …ides-dropdown
    
    keyboard and screenreader support for dropdown in slides and help panes
Commits on Jan 27, 2020
  1. Merge pull request #6040 from rstudio/feature/find-in-package-src

    melissa-barca committed Jan 27, 2020
    Add Package Source to Find In Files include options
  2. simplify comment

    melissa-barca committed Jan 27, 2020
  3. move getIndexFromValue to FormListBox and switch find in files dialog…

    melissa-barca committed Jan 27, 2020
    … to use FormListBox.
    
    When Package Source is selected and the user selects a non-package directory,
    switch include option to All Files
  4. Open source companion commit for rstudio/rstudio-pro#1418

    kfeinauer committed Jan 27, 2020
    Prevent service start failures from continuously attempting to restart the service.
  5. Merge pull request #6097 from rstudio/feature/tweak-a11y-prefs-layout

    gtritchie committed Jan 27, 2020
    move announcements preferences to separate pref pane tab
  6. cleanup spaces before semicolons in files I'm about to work on

    gtritchie committed Jan 27, 2020
Older
You can’t perform that action at this time.