Skip to content
Permalink
Tree: b75cc6d710
Commits on Feb 17, 2020
  1. Merge pull request #6245 from rstudio/bugfix/charat-exceptions

    gtritchie committed Feb 17, 2020
    Replace more instances of String.CharAt with StringUtil.CharAt
  2. Replace more instances of String.CharAt with StringUtil.CharAt

    gtritchie committed Feb 17, 2020
    JavaScript exception related to charAt; don't know exact repro, taking opportunity to fix that call stack and defensively change a few other instances of charAt to use safer StringUtil.charAt.
    
    For more context:
    
    * fix exceptions caused by gwt 2.8.2 checking charAt bounds #4451
    * more fixes for new behavior of String.charAt in GWT 2.8.2 #4489
    * fix exception when typing Shift+Tab on whitespace-only editor line #5036
    * javascript exceptions being thrown by charAt in cpp completion code #5052
    
    Callstack:
    ```
    15 Feb 2020 00:03:26 [rserver] ERROR CLIENT EXCEPTION (rsession-gary): Index: -1, Size: 226;
    rstudio-0.js@10#639::Throwable.createError
    rstudio-0.js@48#703::Throwable.initializeBackingError
    rstudio-0.js@8#535::Throwable.Throwable
    rstudio-0.js@18#808::Exception.Exception
    rstudio-0.js@18#862::RuntimeException.RuntimeException
    rstudio-0.js@25#3620::IndexOutOfBoundsException.IndexOutOfBoundsException
    rstudio-0.js@34#5360::StringIndexOutOfBoundsException
    rstudio-0.js@21#5794::checkCriticalStringElementIndex
    rstudio-0.js@5#6025::checkStringElementIndex
    rstudio-0.js@3#4059::charAt
    rstudio-0.js@10#4633::charAt_I_C__devirtual$
    rstudio-0.js@39#356896::CompletionManagerBase.canAutoPopup
    rstudio-0.js@14#357339::CompletionManagerBase.previewKeyPress
    rstudio-0.js@61#360873::MarkdownCompletionManager.previewKeyPress
    rstudio-0.js@23#359555::DelegatingCompletionManager.previewKeyPress
    rstudio-0.js@43#464919::AceKeyboardPreviewer$1.previewKeyPress
    rstudio-0.js@24#464884::AceKeyboardPreviewer.onTextInput
    rstudio-0.js@21#464852::<anonymous>
    rstudio-0.js@28#16334::apply
    rstudio-0.js@16#16393::entry0
    rstudio-0.js@14#16372::handleKeyboard
    http://localhost:9876/rstudio/7D3FB0FCC17B7BB289C4D681EC4DE752.cache.js@43#42254::callKeyboardHandlers
    http://localhost:9876/rstudio/7D3FB0FCC17B7BB289C4D681EC4DE752.cache.js@14#42290::onTextInput
    http://localhost:9876/rstudio/7D3FB0FCC17B7BB289C4D681EC4DE752.cache.js@36#49554::onTextInput
    http://localhost:9876/rstudio/7D3FB0FCC17B7BB289C4D681EC4DE752.cache.js@22#40398::sendText
    http://localhost:9876/rstudio/7D3FB0FCC17B7BB289C4D681EC4DE752.cache.js@24#40419::onInput
    Client-ID: 3049a086-a908-4534-a87e-4dcaca02d7f7
    User-Agent: Mozilla/5.0 (Macintosh  Intel Mac OS X 10_15_3) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/80.0.3987.106 Safari/537.36
    ```
Commits on Feb 16, 2020
  1. Merge pull request #6242 from rstudio/bugfix/update-static-shortcuts-…

    gtritchie committed Feb 16, 2020
    …reference-page
    
    Bugfix/update static shortcuts reference page
Commits on Feb 15, 2020
  1. update static keyboard shortcuts reference

    gtritchie committed Feb 15, 2020
    - Fixes #6117
  2. Merge pull request #6235 from rstudio/bugfix/replace-windows

    melissa-barca committed Feb 15, 2020
    Fix global replace on Windows
  3. Merge pull request #6238 from rstudio/bugfix/package-install-lock

    kevinushey committed Feb 15, 2020
    Lock via option when installing packages in the background
Commits on Feb 14, 2020
  1. Merge pull request #6234 from rstudio/bugfix/migrate-user-state

    jmcphers committed Feb 14, 2020
    Migrate user state, including context identifier
  2. Fix bug where package OS in About Dialog was showing as "Unknown OS". F…

    kfeinauer committed Feb 14, 2020
    …ixes #6232.
  3. Merge pull request #6224 from rstudio/bugfix/tutorial-relative-run-uri

    kevinushey committed Feb 14, 2020
    use relative tutorial run URI in link
  4. Merge pull request #6222 from rstudio/bugfix/help-pane-tab-handling

    gtritchie committed Feb 14, 2020
    allow Tab key to move focus normally in Help pane secondary toolbar
  5. Merge pull request #6214 from rstudio/bugfix/cleanup-win-bootstrappin…

    gtritchie committed Feb 14, 2020
    …g-qt
    
    cleanup Windows boostrapping scripts and documentation regarding Qt install
Commits on Feb 13, 2020
  1. also require learnr

    kevinushey committed Feb 13, 2020
  2. also ensure rstudioapi is installed before running tutorial

    kevinushey committed Feb 13, 2020
  3. Merge pull request #6207 from rstudio/feature/tutorial-install-depend…

    kevinushey committed Feb 13, 2020
    …encies
    
    install tutorial dependencies before run
  4. Merge pull request #6218 from rstudio/bugfix/pref-warning-monitor-ign…

    jmcphers committed Feb 13, 2020
    …ore-list
    
    fix warning about missing default
Commits on Feb 12, 2020
  1. Merge pull request #6217 from rstudio/bugfix/editor-find-replace-bar-…

    gtritchie committed Feb 12, 2020
    …tab-sequence
    
    Fix editor find / replace bar keyboard tab sequence
  2. fix keyboard focus tab sequence in editor Find/Replace bar

    gtritchie committed Feb 12, 2020
    - remove setting tab indexes > 0 on controls (this should never be done)
    - don't set buttons to tab index -1; they are now able to show keyboard focus, not all of them have equivalent keyboard shortcuts, and those shortcuts are not discoverable to a keyboard/screen reader user without letting focus get to the buttons
  3. cleanup Windows boostrapping scripts and documentation regarding Qt i…

    gtritchie committed Feb 12, 2020
    …nstalls
    
    - eliminated no-longer-working scripted Qt Installer-based install for Windows
    - added additional documentation mentioning need to install Qt manually on dev machines
    - removed scripted-part of install-qt-sdk for Linux, now only used for legacy Qt install via pre-built archive (opensuse)
  4. put back still-needed install-qt-sdk

    gtritchie committed Feb 12, 2020
    - this is still used (partially) by legacy opensuse dockerfile, which installs qt 5.10.1 via an archive
  5. Merge pull request #6209 from rstudio/bugfix/cleanup-linux-qt-bootstr…

    gtritchie committed Feb 12, 2020
    …apper
    
    cleanup bootstrapper scripts for Linux / Qt
  6. Add missing slash in URL

    gtritchie committed Feb 12, 2020
  7. cleanup bootstrapper scripts for Linux / Qt

    gtritchie committed Feb 12, 2020
    - the script that drives Qt Installer no longer works because you must login to the installer with a Qt account
    - the Dockerfiles have been fixed separately to work around this via a minimal Qt SDK install
    - for the developer bootstrap scripts (which are terribly up-to-date to begin with) just stripped out the now broken Qt installation step and added notes to the README (and the wiki) about needing to install Qt yourself if you want to build desktop on Linux
    - also added note in README suggesting consulting the Dockerfiles when determining dependencies for a different system, as those are more up-to-date than the bootstrapper scripts
Older
You can’t perform that action at this time.