Skip to content
Permalink
Tree: f6fe927b4e
Commits on Jan 14, 2020
  1. Merge pull request #6010 from rstudio/bugfix/env-pane-image-alt

    gtritchie committed Jan 14, 2020
    provide alt-text for images in Environment pane
  2. provide alt-text for images in Environment pane

    gtritchie committed Jan 14, 2020
    - image for expandable object, traced object, and current frame of callstack didn't have labels
Commits on Jan 13, 2020
  1. remove spaces before trailing semicolons

    gtritchie committed Jan 13, 2020
  2. Merge pull request #6009 from rstudio/feature/f13-f19-shortcuts

    jmcphers committed Jan 13, 2020
    support F13 - F24 for custom keyboard shortcuts
  3. support F13 - F24 for custom keyboard shortcuts

    gtritchie committed Jan 13, 2020
    - Tested with Full Mac keyboard which includes F13 to F19
    - Also works with Windows if you have a keyboard with these keys
    - Keys / keycodes up to F24 are defined
  4. Merge pull request #6003 from rstudio/bugfix/latchingtoolbarbutton-to…

    gtritchie committed Jan 13, 2020
    …ggle-a11y
    
    use aria-pressed to make LatchingToolbarButton a toggle button
  5. use aria-pressed to make LatchingToolbarButton a toggle button

    gtritchie committed Jan 13, 2020
    - in one use of this control (for showing/hiding document outline), the accessibility text is changed to indicate the state of the button; in that situation it is NOT appropriate to use aria-pressed as the text is sufficient to tell screen readers what is going on
    - in the other use, the Filter button in the data viewer, the text does not change, so aria-pressed is required to indicate that this is a toggle button and to indicate what state it is currently in
  6. Merge pull request #6002 from rstudio/feature/editor-pane-a11y-improv…

    gtritchie committed Jan 13, 2020
    …ements
    
    Accessibility improvements to editor pane
  7. fixes to source-pane accessibility

    gtritchie committed Jan 13, 2020
    - make document outline view aria-hidden when visibly hidden
    - annotate document outline view splitter
    - initial wiring for command to speak editor status
    - mark various source pane tabpanels with correct role, and give them labels (text editor, object explorer, code browser, data viewer, url viewer. profile results)
    -
Commits on Jan 12, 2020
  1. Merge pull request #5996 from rstudio/bugfix/keyboard-screenreader-mi…

    gtritchie committed Jan 12, 2020
    …n-max-quadrant-btns
    
    make min/max/restore quadrant controls fully accessible
Commits on Jan 11, 2020
Commits on Jan 10, 2020
  1. Open source companion commit for rstudio/rstudio-pro#1392

    kfeinauer committed Jan 10, 2020
  2. make min/max/restore quadrant controls fully accessible

    gtritchie committed Jan 10, 2020
    - the controls to the right of tabs for minimizing, maximizing, and restoring each quadrant can now be operated by screen reader and/or keyboard, and report distinctive names indicating both which quadrant they are in, and their current state (min/max/restore)
    - also gave each a unique, stable elementId
  3. Add error logging when a version is being skipped for an invalid path…

    kfeinauer committed Jan 10, 2020
    … in extended R versions definitions
  4. Merge pull request #5989 from rstudio/bugfix/menu-indicate-screenread…

    gtritchie committed Jan 10, 2020
    …er-mode
    
    include screen reader state in menu text to workaround Qt bug
  5. Merge pull request #5990 from rstudio/bugfix/next-prev-terminal-short…

    gtritchie committed Jan 10, 2020
    …cuts
    
    change keyboard shortcuts for next/prev terminal to use Shift instead of Ctrl
Commits on Jan 9, 2020
  1. change keyboard shortcuts for next/prev terminal to use Shift instead…

    gtritchie committed Jan 9, 2020
    … of Ctrl
    
    - avoids a clash with commonly used shortcuts on Windows
    - issue reported it on Dell XPS, I was also seeing the same problem on my Lenovo IdeaPad
    - tested the next shortcuts on those, macOS Desktop, and Server on Mac and Windows in Chrome
  2. include screen state in menu text to workaround Qt bug

    gtritchie committed Jan 9, 2020
    - on Windows desktop, Qt has a bug preventing screen readers from knowing if a menu item has a checkbox so a blind user can't tell current state of the "Help / Accessibility / Screen Reader Support" menu item
    - this is particularly bad because the other way to see this state is in the accessibility preferences pane (via a regular checkbox), but this isn't accessible until screen reader support is on
    - add (enabled) or (disabled) to the menu item to provide an additional indication of state
    - not making Windows-desktop specific, doesn't do any harm to have this extra information in all cases
    - not implementing a generic fix for all checkable menu items, will consider on a case-by-case basis
  3. Merge pull request #5988 from rstudio/bugfix/tutorial-home

    jmcphers committed Jan 9, 2020
    Install supporting tutorial files
  4. Merge pull request #5981 from rstudio/bugfix/label-landmarks-warningbar

    gtritchie committed Jan 9, 2020
    label nav and main landmarks, give warningbar a role and make its close btn accessible
  5. Merge pull request #5983 from rstudio/bugfix/assorted-a11y-2020-01-08

    gtritchie committed Jan 9, 2020
    fix assorted accessibility issues in build output toolbars, connections UI
  6. fix assorted accessibility issues in build output toolbars, connectio…

    gtritchie committed Jan 9, 2020
    …ns UI
    
    - connection code editor not labeled in pane instance, and incorrectly labeled in dialog instance
    - tab traps in connection code editor in connection dialog and pane
    - contrast too low on "no connections" message in pane
    - animation when showing/hiding git infobar wasn't obeying reduced motion setting
    - toolbar class used in CompilePDFOutput, RenderRmdOutput, RSConnectDeployOutput, and TestsOutput panes had the same name in all of them ("Compile Output Tab", now it has a name representative of the tab
    - using aria-label on the username in toolbar was not valid and not useful in screen readers
    - progress spinner canvas control used in "busy" tabs now read as "Busy", so a tab will read "Some Tab Busy" in screen reader when spinner is showing
Commits on Jan 8, 2020
  1. embed rstudioapi

    kevinushey committed Jan 8, 2020
  2. Merge pull request #5881 from rstudio/feature/tutorial-support

    kevinushey committed Jan 8, 2020
    initial wiring for learnr + tutorial pane
  3. tidying up

    kevinushey committed Jan 8, 2020
  4. Merge pull request #5976 from rstudio/feature/banner-nav-main-landmar…

    gtritchie committed Jan 8, 2020
    …ks-a11y
    
    apply banner, nav, and main landmarks to IDE main window, remove application role
  5. Merge pull request #5974 from rstudio/bugfix/main-menu-voiceover-tweaks

    gtritchie committed Jan 8, 2020
    give dropdown menus the menu role instead of menubar role, per aria guidelines
  6. apply banner, nav, and main landmarks to IDE main window, remove appl…

    gtritchie committed Jan 8, 2020
    …ication role pref
    
    - the application role setting was an experiment, after further discussions with accessibility experts, removing
    - don't put alt="RStudio" on the logo in upper-left of the IDE, it's a distraction when using screen readers
    - give the logo the banner role; if it has a link (i.e. on server-pro) then it will show up as a landmark
    - give the menu and toolbar areas the navigation role
    - give the tab panel area the main role, instead of the entire page
    - mark a layout table used only when the toolbar is hidden as role=presentation
    -
  7. cleaning up

    kevinushey committed Jan 8, 2020
Older
You can’t perform that action at this time.