Permalink
Switch branches/tags
Commits on Nov 15, 2011
  1. Remember whether to remember password

    jcheng5 committed Nov 15, 2011
    This should go into project options, will take a look at that next
Commits on Nov 14, 2011
  1. Rename event

    jcheng5 committed Nov 14, 2011
  2. Fail forward quietly for unstage

    jcheng5 committed Nov 14, 2011
  3. Fix SSH key bugs on Windows

    jcheng5 committed Nov 14, 2011
  4. Robust, optional remembering of SSH passphrases

    jcheng5 committed Nov 14, 2011
    Existing logic for remembering SSH passphrases was extremely fragile and complicated due to SSH_ASKPASS not working on Windows, because we weren't detaching the process correctly. Now that we do detach correctly, we can get rid of the existing complicated machinery and replace it with something much simpler, more robust, and optional.
    
    Previously we used GIT_SSH to intercept calls to SSH, then we'd preemptively start ssh-agent and add what we thought was the key the user would need to use. If that key was encrypted with a passphrase, we used an SSH_ASKPASS override (that worked for ssh-add, but not ssh, due to differing logic between them for when they would invoke SSH_ASKPASS).
    
    Now we no longer set GIT_SSH, but rather rely solely on SSH_ASKPASS. If the passphrase prompt we're given looks like it's for a key file, then we ask the user for a passphrase and also ask if the passphrase should be remembered. If so, we run ssh-agent (if it's not already running) and persist the key, this time overriding SSH_ASKPASS to a different script that just outputs the passphrase.
  5. Fix issues on Ubuntu

    jcheng5 committed Nov 12, 2011
    - Can't use runProgram without an absolute path on Linux
    - Shell arguments can't be escaped
  6. Fix various git problems on Windows

    jcheng5 committed Nov 11, 2011
    - Project paths with spaces in them would cause errors. Turns out runProgram does not do arg escaping.
    - Distinguish between detachSession (calls setsid on POSIX) and detachProcess (passes DETACHED_PROCESS on Windows). The former is almost always what we want and the latter is usually not what we want (as using it with runCommand will lead to a command prompt window appearing!)
    - Don't let git code get called if the project is not in a git repo
  7. Implement detached win32 child processes

    jcheng5 committed Nov 11, 2011
    This allows our SSH_ASKPASS impl to finally work right on Windows!
  8. Fix git on windows

    jcheng5 committed Nov 11, 2011
  9. Big refactor of SessionGit

    jcheng5 committed Nov 10, 2011
    Unify the different code paths for invoking commands.
  10. De-generify source control code

    jcheng5 committed Nov 10, 2011
  11. Some file renaming

    jcheng5 committed Nov 10, 2011
  12. factor out core vcs operations (refresh, pull, push, ask-pass) into V…

    jjallaire committed Nov 14, 2011
    …CSCore so they also work in the vcs satellite
Commits on Nov 12, 2011
  1. add comments

    jjallaire committed Nov 12, 2011
Commits on Nov 11, 2011
  1. add todo comments

    jjallaire committed Nov 11, 2011
  2. update comment

    jjallaire committed Nov 11, 2011