Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support changes to R 4.2.0 help system #10839

Closed
kevinushey opened this issue Mar 24, 2022 · 1 comment
Closed

Support changes to R 4.2.0 help system #10839

kevinushey opened this issue Mar 24, 2022 · 1 comment
Assignees
Labels
backport backport-prairie-trillium

Comments

@kevinushey
Copy link
Contributor

@kevinushey kevinushey commented Mar 24, 2022

From wch/r-source@1c74636:

  \item The HTML help system has several new features: LaTeX-like
  math can be typeset using either \href{https://katex.org/}{KaTeX}
  or \href{https://www.mathjax.org/}{MathJax}, usage and example
  code are highlighted using \href{https://prismjs.com}{Prism}, and
  for dynamic help the output of examples and demos can be shown
  within the browser if the \CRANpkg{knitr} package is
  installed. These features can be disabled by setting the
  environment variable \code{_R_HELP_ENABLE_ENHANCED_HTML_} to a
  false value.

The enhanced help system looks good with light RStudio themes:

Screen Shot 2022-03-24 at 10 59 34 AM

But not so great with dark RStudio themes:

Screen Shot 2022-03-24 at 11 00 00 AM

We'll likely need to tweak our Help pane CSS to support the new Help rendering.

@kevinushey kevinushey self-assigned this Mar 25, 2022
@kevinushey kevinushey modified the milestones: Spotted Wakerobin (2022.06.0), Prairie Trillium (2022.02.2) Mar 28, 2022
@mikebessuille mikebessuille modified the milestones: Prairie Trillium (2022.02.2), Spotted Wakerobin (2022.06.0) Apr 7, 2022
@mikebessuille mikebessuille added the backport label Apr 12, 2022
@ronblum
Copy link
Contributor

@ronblum ronblum commented Apr 13, 2022

Verified using ?Normal that text is displayed correctly using several light and dark themes in

  • RStudio Desktop 2022.02.2+481 (Prairie Trillium)
  • RStudio Server 2022.02.2+481 (Prairie Trillium)
  • RStudio Desktop 2022.06.0-daily+295 (Spotted Wakerobin)

Also verified that no impact in R 4.1.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport backport-prairie-trillium
Projects
None yet
Development

No branches or pull requests

3 participants