Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RStudio Server dark theme does not work on dataframe panel without clearing cache after upgrade to 1.1 from 1.0 #1573

Closed
likso opened this issue Oct 10, 2017 · 13 comments
Assignees
Labels
Milestone

Comments

@likso
Copy link

@likso likso commented Oct 10, 2017

Look like the dataframe panel always keep as light theme even when in dark theme mode. It makes the row name and col name unreadable.

Rstudio theme: Modern
Editor theme: Solarized Dark

image

@dfalty
Copy link

@dfalty dfalty commented Oct 10, 2017

What platform and version of RStudio are you running?
This looks fine for me on 1.1.383 with Modern/Solarized Dark (Mac OS).
image

@likso
Copy link
Author

@likso likso commented Oct 10, 2017

It is strange. I login with another PC which works good. However the original one is still not working even they are on the same session.
Both clients are on windows 10 64-bit Chrome 61.0.3163.100 (Official Build) (64-bit).
RStudio Server 1.1.383 with Ubuntu 16.04.3 LTS.

image
image

@glenn-m
Copy link

@glenn-m glenn-m commented Oct 11, 2017

We have been seeing this happening as well, can't really pinpoint what's causing it.

Chrome Version 60.0.3112.90 (Official Build) (64-bit)
Windows 7 64-bit
RStudio Server 1.1.383 with Redhat 6.6

@dfalty
Copy link

@dfalty dfalty commented Oct 11, 2017

Thanks for the info!

@javierluraschi do you know what could cause the theme to fail within the data viewer like this? I'm unable to repro locally.

@dfalty dfalty added the low label Oct 11, 2017
@javierluraschi javierluraschi self-assigned this Oct 11, 2017
@javierluraschi
Copy link
Contributor

@javierluraschi javierluraschi commented Oct 11, 2017

@likso @gsmcd could you right-click over one of the cells with incorrect background and select inspect?

Then if you could share a screenshot like the one below it would be much appreciated.

Notice that I expanded the <head> tag a few lines above from the inspected element and then clicked on <tr> to get a view of the CSS styles being applied.

screen shot 2017-10-11 at 10 45 20 am

@glenn-m
Copy link

@glenn-m glenn-m commented Oct 11, 2017

@javierluraschi Hmm. I went to get a screenshot for you there, but I'm unable to reproduce it now! It's odd, as I had a handful of users reporting this.

@likso Are you able to reproduce this?

@javierluraschi
Copy link
Contributor

@javierluraschi javierluraschi commented Oct 11, 2017

@gsmcd @likso couple question that could help me debug this: Do you both have multiple RStudio windows open? Did you switch to use the dark-theme during or was this reproducing for you from a brand new RStudio window?

@glenn-m
Copy link

@glenn-m glenn-m commented Oct 12, 2017

@javierluraschi I've tried a couple more things:

  1. Start a new session with default color scheme and move to Solarized Dark, however the table changes color as expected.
  2. I also tried with multiple windows open, and it's working as expected.

The only thing I can think of is something has been cached from the older RStudio Server version? As this happened immediately after the upgrade. The users that originally reported the issue to me have now said it's working as expected.

@javierluraschi javierluraschi changed the title RStudio Server dark theme does not work on dataframe panel RStudio Server dark theme does not work on dataframe panel without clearing cache after upgrade Oct 12, 2017
@javierluraschi
Copy link
Contributor

@javierluraschi javierluraschi commented Oct 12, 2017

Thanks @gsmcd, this seems to be the case, I manually reverted the changes to gridstyle.css (to simulate that this file is cached between RSP versions) and got something very close to your repro:

screen shot 2017-10-12 at 10 41 51 am

So I believe the repro for this one is as follows:

  1. Install RStudio Server 1.0
  2. Trigger to View(iris)
  3. Upgrade to RStudio Server 1.1
  4. Refresh Browser

The workaround is something like, close all your browser windows, or explicitly clear cache.

@javierluraschi javierluraschi changed the title RStudio Server dark theme does not work on dataframe panel without clearing cache after upgrade RStudio Server dark theme does not work on dataframe panel without clearing cache after upgrade to 1.1 from 1.0 Oct 12, 2017
@likso
Copy link
Author

@likso likso commented Oct 12, 2017

@javierluraschi I did not have multiple Rstudio windows opened. It happened straight after my upgrade from 1.0 to 1.1.

@jmcphers jmcphers added this to the v1.1-patch milestone Oct 16, 2017
@jmcphers
Copy link
Member

@jmcphers jmcphers commented Oct 17, 2017

jmcphers added a commit that referenced this issue Dec 1, 2017
Some RStudio Server users have reported that they see a mix of white and
dark in the data viewer after upgrading to RStudio 1.1 and applying a
dark them, ostensibly because they're getting a cached 1.0 copy of the
styles. This change updates the CSS filenames (and others in the folder)
to ensure that 1.0 copies won't be used with 1.1.
@jmcphers
Copy link
Member

@jmcphers jmcphers commented Dec 1, 2017

Backported to 1.1 in 976735a.

@dfalty dfalty added the verified label Dec 4, 2017
@dfalty
Copy link

@dfalty dfalty commented Dec 4, 2017

I can't reproduce this on the 1.1 patch build 1.1.393 so I'll mark this as verified. Let us know if you are able to reproduce.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants