Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suppress session suspension when external pointers are present in the global environment #1696

Closed
jmcphers opened this issue Oct 31, 2017 · 3 comments
Closed

Suppress session suspension when external pointers are present in the global environment #1696

jmcphers opened this issue Oct 31, 2017 · 3 comments
Assignees
@jmcphers
Labels
enhancement
Milestone
v1.1-patch

Comments

@jmcphers
Copy link
Member

@jmcphers jmcphers commented Oct 31, 2017

R objects can include external pointers. When these are present in the global environment, RStudio should suppress the automatic session suspension which would ordinarily occur; the external pointers cannot be restored, so when the session resumes after suspension, those objects which contain them will not work, and may cause crashes or instability.
@jmcphers jmcphers self-assigned this Oct 31, 2017
@jmcphers jmcphers added this to the v1.1-patch milestone Oct 31, 2017
jmcphers added a commit that referenced this issue Nov 1, 2017
@jmcphers
Merge pull request #1697 from rstudio/feature/external-ptr-suspend
dba7e22 
Don't suspend sessions with external pointers (fixes #1696)
jmcphers added a commit that referenced this issue Nov 16, 2017
@jmcphers
don't suspend sessions with external pointers (fixes #1696)
b327955
@jmcphers
Copy link
Member Author

@jmcphers jmcphers commented Nov 16, 2017

Backported to 1.1 here: b327955

@dfalty dfalty added the verified label Dec 4, 2017
@dfalty
Copy link

@dfalty dfalty commented Dec 4, 2017

Verified 1.1.393.

@dfalty
Copy link

@dfalty dfalty commented Jan 23, 2018

Verified this again on 1.1.419.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jmcphers jmcphers

Labels
enhancement
Projects
None yet
Milestone
v1.1-patch
Development

No branches or pull requests
2 participants
@jmcphers @dfalty