Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[enhancement] add .editorconfig support #1711

Open
rbirkelbach opened this issue Nov 3, 2017 · 6 comments
Open

[enhancement] add .editorconfig support #1711

rbirkelbach opened this issue Nov 3, 2017 · 6 comments
Milestone

Comments

@rbirkelbach
Copy link

@rbirkelbach rbirkelbach commented Nov 3, 2017

Hello,

would it be possible to add .editorconfig support for rstudio? See here: http://editorconfig.org/
If possible, a second improvement would be to add an .editorconfig file to each new rstudio project with sane defaults (e.g. use Hadley Wickham's styleguide).
This would make collaborating much easier and nicer.

Thanks!

@rbirkelbach rbirkelbach reopened this Nov 3, 2017
@rbirkelbach rbirkelbach changed the title [enhancement [enhancement] add .editorconfig support Nov 3, 2017
@jmcphers
Copy link
Member

@jmcphers jmcphers commented Nov 3, 2017

We're big fans of .editorconfig (see e.g. https://github.com/rstudio/rstudio/blob/master/src/cpp/.editorconfig). :-) No ETA yet but this is on our wishlist too!

@katrinleinweber
Copy link

@katrinleinweber katrinleinweber commented Feb 12, 2018

Would this mean that StripTrailingWhitespace, UseSpacesForTab and NumSpacesForTab be removed from .Rproj? If so, the argument behind that would be to separate style settings from others, which may be more personal for each RStudio users, correct?

@jmcphers
Copy link
Member

@jmcphers jmcphers commented Feb 22, 2018

.editorconfig is part of the project, just like .Rproj -- so it doesn't really make it personal for each user. The goal is to keep the style consistent in the project. .Rproj helps with that as long as all the collaborators are using RStudio. .editorconfig is similar, but it is more flexible (you can set defaults per directory and per filetype, for instance) and is supported by many editors other than RStudio.

@katrinleinweber
Copy link

@katrinleinweber katrinleinweber commented Feb 23, 2018

Yes, I know. What I'm wondering is whether those non-personal, project-wide editor settings will be moved from .Rproj to .editorconfig? Currently, the former is sometimes not commited because it also contains settings which seem more personal (...Workspace & ...History). Unfortunately, such concerns then make it harder to keep the non-personal style elements consistent across different contributors.

@rbirkelbach
Copy link
Author

@rbirkelbach rbirkelbach commented Apr 9, 2018

Maybe instead of embedding editorconfig in RStudio, it would be easier (I don't know, it's just an idea) to create a translator from editorconfig to rstudioprojects and the other way around?

@stale
Copy link

@stale stale bot commented Feb 6, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs, per https://github.com/rstudio/rstudio/wiki/Issue-Grooming. Thank you for your contributions.

@stale stale bot added the stale label Feb 6, 2021
@jmcphers jmcphers added this to the v1.6 milestone Feb 8, 2021
@stale stale bot removed the stale label Feb 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants