Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load All shortcut doesn't work when Terminal is open #1723

Closed
jmcphers opened this issue Nov 7, 2017 · 3 comments
Closed

Load All shortcut doesn't work when Terminal is open #1723

jmcphers opened this issue Nov 7, 2017 · 3 comments
Assignees
Labels
Milestone

Comments

@jmcphers
Copy link
Member

@jmcphers jmcphers commented Nov 7, 2017

Repro:

  1. Create or open a Package project
  2. Put the cursor in the R console
  3. Press Ctrl + Shift + L; this is a shortcut for Load All and should emit devtools::load_all(".") to the console
  4. Open the Terminal and type a command
  5. Put the cursor back in the R console
  6. Press Ctrl + Shift + L again

Nothing happens.

Originally reported here: https://community.rstudio.com/t/bug-report-ctrl-shift-l-stops-working/1999

@gtritchie
Copy link
Member

@gtritchie gtritchie commented Nov 8, 2017

This is because there is a Ctrl+Shift+L shortcut for the Clear Terminal Buffer command (left over from before I made Ctrl+L clear the Terminal instead of the Console depending on focus).

So as soon as there's a terminal instance, Ctrl+Shift+L starts being routed to it, even when it isn't visible.

I think I should remove this shortcut altogether, since Ctrl+L already does the trick.

In the meantime, users can modify the keyboard shortcut and remove it themselves. Tools / Modify Keyboard Shortcuts, type clear terminal in the filter, double-click on the Shift + Ctrl + L, delete it, and Apply.

2017-11-07_21-37-52

@jcpayne
Copy link

@jcpayne jcpayne commented Nov 13, 2017

@gtritchie's fix worked for me, but I had to restart RStudio before the change took effect. Also in my case, the terminal wasn't open and the shortcut still got hijacked.

@ronblum ronblum self-assigned this Nov 14, 2017
jmcphers pushed a commit that referenced this issue Nov 16, 2017
@ronblum
Copy link
Contributor

@ronblum ronblum commented Dec 5, 2017

Verified in RStudio server and desktop v1.1.393.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants