Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for arrow keys in editor on the iPad #2186

Closed
jmcphers opened this issue Feb 12, 2018 · 7 comments
Closed

Add support for arrow keys in editor on the iPad #2186

jmcphers opened this issue Feb 12, 2018 · 7 comments
Assignees
Milestone

Comments

@jmcphers
Copy link
Member

@jmcphers jmcphers commented Feb 12, 2018

System details

RStudio Edition : Server
RStudio Version : 1.2.300
OS Version      : iOS 11

Steps to reproduce the problem

  1. Set focus to the editor pane
  2. Press the arrow keys a few times

Describe the problem in detail

Nothing happens.

Describe the behavior you expected

The arrow keys should work on the iPad. The reason they don't is that -- for some reason -- Safari does not send arrow keycodes on iOS.

There is a fix for this in newer versions of Ace, which @gtritchie discovered while researching the issue in xterm.js:

https://github.com/ajaxorg/ace/blob/eb2437badf4013893e15cb873057607c09cc95ae/lib/ace/keyboard/textinput_ios.js#L483-L526

We probably don't have the resources to pick up an entirely new Ace in this release, but the code above might be relatively easily inserted into our existing Ace installation to add support for arrow keys.

@jmcphers jmcphers added this to the v1.2 milestone Feb 12, 2018
@gtritchie
Copy link
Member

@gtritchie gtritchie commented Feb 12, 2018

Finally I can justify owning an iPad Pro.

@bbjonz
Copy link

@bbjonz bbjonz commented Mar 25, 2018

This fix would be wonderful. It’s not clear to me, though, where to add the js code to RStudio Server. Some help in that direction would be much appreciated.

@gtritchie
Copy link
Member

@gtritchie gtritchie commented Mar 25, 2018

I’m working on it now. :-)

@bbjonz
Copy link

@bbjonz bbjonz commented Mar 25, 2018

Fantastic! I really appreciate it. Like you, I’m looking forward to justifying owning an iPad Pro!

@kkleinoros
Copy link

@kkleinoros kkleinoros commented Dec 28, 2018

Has this problem been resolved yet?

@kevinushey
Copy link
Contributor

@kevinushey kevinushey commented Jan 7, 2019

You can give it a trial run in the preview release.

@bbjonz
Copy link

@bbjonz bbjonz commented Jan 7, 2019

I've been running preview releases for over a month and the problem seems to have been resolved.

@rich-rstudio rich-rstudio self-assigned this Jan 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants