Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Online (real-time) spell checking #2825

Closed
jmcphers opened this issue May 22, 2018 · 4 comments
Closed

Online (real-time) spell checking #2825

jmcphers opened this issue May 22, 2018 · 4 comments
Assignees

Comments

@jmcphers
Copy link
Member

@jmcphers jmcphers commented May 22, 2018

RStudio has a built-in spell checker which can be invoked with e.g. F7. However, many users have requested online spell checking in RStudio; that is, words spelled incorrectly are highlighted in some way as soon as they're typed, without the need to manually invoke the checker.

https://community.rstudio.com/t/underline-misspelled-words-in-rstudio/8235/2

https://stackoverflow.com/questions/31653319/spell-check-in-rstudio/

Our editor, Ace, doesn't itself doesn't embed a spell checker; although it can integrate with the browser's spell checker, it can't do context-sensitive checking, which is what we'd need since the most relevant place for spell checking in RStudio is in R Markdown documents, which contain a mix of content that requires spell checking (prose) and content that doesn't (R code).

See also this old project to add spell check to Ace and typo.js.

One of the reasons we haven't done this yet is that the F7 spell check, if simply turned into an online spell checker, probably wouldn't be satisfactory, as there are a number of rough edges that would suddenly become very abrasive. In particular:

  1. we need to spell check the correct regions of each file type; for example, we don't check headings right now (#1588), and spelling in comments of R files would be nice too
  2. many domain specific terms aren't in the default dictionary
  3. the UX for suggestions/ignoring/adding to a dictionary would need some polish and would also need to be added to a context menu.
@mcfrank
Copy link

@mcfrank mcfrank commented Dec 23, 2018

Thanks @adamconroy for working on this - let me know if you need alpha testing. :) I am a big advocate for RStudio + RMarkdown as the reproducible writing solution and would love to see this feature as it's a key part of convincing people to write in RStudio rather than say word or gdocs.

@kevinushey kevinushey added this to the v1.3 milestone Feb 19, 2019
@benmarwick
Copy link

@benmarwick benmarwick commented May 27, 2019

I recently spotted live, on-the-fly spell checking in OSX v.1.3.118 and later, which can be downloaded from https://dailies.rstudio.com/ Thanks, @adamconroy ! (#4762)

@jmcphers
Copy link
Member Author

@jmcphers jmcphers commented Aug 27, 2019

This is implemented now. If anyone would like to try it, you can do so using our daily builds:

https://dailies.rstudio.com/

Check the "Real time spellchecking" preference here:

image

This preference is currently off by default in the daily builds, but will be on by default when we release a preview with this functionality.

@mcfrank
Copy link

@mcfrank mcfrank commented Aug 27, 2019

👏 👏 👏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants