Rstudio desktop free preview 1.2.1329 - can't select text in editor window #4488

rgayler · 2019-03-20T23:18:27Z

I just upgraded from 1.2.1327 to 1.2.1329 and can no longer select text in (at least) the editor window. Click-drag does not select text. Double-click does not select text. Editing is almost unusable.

The behaviour survived a restart of Rstudio and a reboot of the computer. Other programs were fine.

I reverted to 1.2.1327 and the problem disappeared.

I am running the Ubuntu 18+ versions of Rstudio.

My computer is running Ubuntu 18.04 4-bit.

gtritchie · 2019-03-21T00:05:30Z

I just installed 1.2.1329 (Bionic) on a clean install of Bionic + r-base, and am able to select text in the editor via click-drag, double-click, and so on.

So something else is going on here.

rgayler · 2019-03-21T00:17:50Z

Any suggestions what I might try to do to investigate this? (Although I am mid-project and behind-deadline at the moment, so ...)

…

On Thu, 21 Mar 2019 at 11:05, Gary ***@***.***> wrote: I just installed 1.2.1329 (Bionic) on a clean install of Bionic + r_base, and am able to select text in the editor via click-drag, double-click, and so on. So something else is going on here. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#4488 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AFKJG59lnV9pOCnQwrWybrC46XcyN_W5ks5vYszQgaJpZM4cAc60> .

gtritchie · 2019-03-21T03:31:41Z

I recommend posting what you've encountered on the community page and see if anybody else reports the same. That might give us more data to work with in understanding what you are experiencing. https://community.rstudio.com/c/rstudio-ide

rgayler · 2019-03-21T03:33:16Z

Thanks. Will do.

…

On Thu, 21 Mar 2019 at 14:31, Gary ***@***.***> wrote: I recommend posting what you've encountered on the community page and see if anybody else reports the same. That might give us more data to work with in understanding what you are experiencing. https://community.rstudio.com/c/rstudio-ide — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#4488 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AFKJG6Sgt8970crWUewvt_3srd1tQ7KTks5vYv0jgaJpZM4cAc60> .

rgayler · 2019-03-21T11:15:12Z

I have just reproduced the problem on a different computer running Ubuntu 18.04. The two computers showing the same problem are not identically configured, but I do generally install the same things on both - so there may be something relatively uncommon that I am doing on both that interacts with whatever changed between 1.2.1327 and 1.2.1329

gtritchie · 2019-03-21T16:12:03Z

Which keybinding are you using for the editor? E.g. Default, Vim, Emacs, Sublime Text.

Does this problem only happen in the editor pane? How about the Console?

Reproduce the problem again, then Help / Diagnostics / Write Diagnostics Report and attach the generated file to this issue. Review it first to make sure there isn't anything in there you need to redact for privacy reasons.

Here's a brief example of what I'm trying:

gtritchie · 2019-03-21T16:40:14Z

There were 3 changes made between 1.2.1327 and 1.2.1329.

Two of them are related to using themes. What theme do you have selected in Tools / Global Options / Appearance? I've got the default selected (Textmate). If you've got a different one, does the problem still happen if you switch back to Textmate?

The other change would prevent saving a file if you did options(repos = NULL) then tried to save a file, so seems quite unlikely it is a factor.

gtritchie · 2019-03-21T16:46:19Z

FYI, I also tried installing 1.2.1327, using it a bit, then uninstalling it and installing 1.2.1329 and it still worked (selection-wise).

jjallaire · 2019-03-25T14:58:14Z

I think I am seeing the same thing.

I updated to the preview yesterday (from either 1.2.1300 or 1.2.1320, not sure which I was running) and now find my IDE in a state where no syntax highlighting works and text selections are impossible! Here's a video:

The only thing I see in the JS console is this:

Interestingly, if I switch to another theme (I tried "Solarized Dark") then everything works fine. If I think explicitly switch back to TextMate, everything works fine (and there is no error in the JS console when I do a reload).

So something to do with having no theme explicitly set in preferences? Maybe this commit from 8 days ago: 8c9a28e

kevinushey · 2019-03-25T15:54:43Z

I see a similar query for the theme that works fine:

although curious is that your case has the double-slash in the URL.

kevinushey · 2019-03-25T16:18:25Z

It might be related to this older commit: eafd6b7#diff-ecbf3c3e6509a5a8a5a76289bbd60514

It looks like we previously expected / used leading slashes in the theme URLs, and have since removed them. However, I suspect the saved URLs might still contain these leading slashes, and so when these old themes get used the issue comes up.

@rgayler, can you confirm whether changing the editor theme fixes the issue for you?

gtritchie · 2019-03-25T16:23:19Z

I see a slightly different failure; no double-slash, but there's an extra "ace" in the path. This is thrown when the Options dialog tries to load the theme preview (and is on 1.3 dev server build, so that might be a factor).

kevinushey · 2019-03-25T16:48:20Z

That's almost surely a v1.3-ism. Ace has some code that tries to auto-load the textmate theme on startup that took some work to cauterize in v1.2; I expect we'll need the same in v1.3 (and I recall seeing some updates on the Ace side around how themes were loaded)

gtritchie · 2019-03-25T16:50:39Z

Yes, I've only been able to repro with 1.3. Opening a separate issue to track that one. #4504

jmcphers · 2019-03-25T17:04:47Z

However, I suspect the saved URLs might still contain these leading slashes, and so when these old themes get used the issue comes up.

That's very possible. I was able to reproduce @jjallaire's issue by hand-modifying my user-settings to introduce a leading / in the theme name.

kevinushey · 2019-03-25T17:09:48Z

I've got the following repro steps:

Clean out ~/.rstudio-desktop;
Install RStudio v1.2.900, and change the theme (so that theme settings get persisted);
Install the latest preview, and observe no theming in the IDE.

The issue does indeed resolve after changing the theme a second time.

On our side, I think the simplest fix is to just trim out a potential leading slash here:

rstudio/src/gwt/src/org/rstudio/studio/client/workbench/views/source/editors/text/themes/AceTheme.java

Lines 60 to 63 in eb68de9

    
              public native final String getUrl() 
        
              /*-{ 
        
                 return this.url; 
        
              }-*/;

jmcphers · 2019-03-25T17:11:32Z

I was also able to repro this by hand-editing the ~/.rstudio-desktop/monitored/user-settings/user-settings file directly.

@MariaSemple, what do you think about making a change here for 1.2?

jmcphers · 2019-03-27T22:36:17Z

Should be fixed by #4506 (note: merged to patch branch so not yet part of a public build)

rgayler · 2019-03-27T23:48:11Z

My apologies for not responding earlier - I have been unavailable all week

…

On Thu, 28 Mar 2019 at 09:36, Jonathan ***@***.***> wrote: Closed #4488 <#4488>. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#4488 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AFKJG-L-V9AQNAX2fiRcuJqEi_W04ye7ks5va_JogaJpZM4cAc60> .

ronblum · 2019-06-07T15:29:14Z

Verified in RStudio Desktop 1.2.1539 on MacOS 10.14.6 and Ubuntu 18.04.2.

gtritchie added the repro needed label Mar 21, 2019

jmcphers added the themes label Mar 25, 2019

jmcphers assigned MariaSemple Mar 25, 2019

jmcphers removed the repro needed label Mar 25, 2019

jmcphers added this to the v1.2-patch milestone Mar 25, 2019

MariaSemple mentioned this issue Mar 25, 2019

Fix an issue caused by old versions of RStudio saving themes with a leading slash. #4506

Merged

kevinushey mentioned this issue Mar 26, 2019

No color in editor/console panes #4509

Closed

jmcphers closed this as completed Mar 27, 2019

ronblum added bug verifying labels Jun 3, 2019

ronblum added verified and removed verifying labels Jun 7, 2019

Rstudio desktop free preview 1.2.1329 - can't select text in editor window #4488

Rstudio desktop free preview 1.2.1329 - can't select text in editor window #4488

rgayler commented Mar 20, 2019 •

edited

gtritchie commented Mar 21, 2019 •

edited

rgayler commented Mar 21, 2019

gtritchie commented Mar 21, 2019

rgayler commented Mar 21, 2019

rgayler commented Mar 21, 2019

gtritchie commented Mar 21, 2019

gtritchie commented Mar 21, 2019

gtritchie commented Mar 21, 2019

jjallaire commented Mar 25, 2019

kevinushey commented Mar 25, 2019

kevinushey commented Mar 25, 2019

gtritchie commented Mar 25, 2019 •

edited

kevinushey commented Mar 25, 2019 •

edited

gtritchie commented Mar 25, 2019 •

edited

jmcphers commented Mar 25, 2019

kevinushey commented Mar 25, 2019

jmcphers commented Mar 25, 2019

jmcphers commented Mar 27, 2019

rgayler commented Mar 27, 2019

ronblum commented Jun 7, 2019

Rstudio desktop free preview 1.2.1329 - can't select text in editor window #4488

Rstudio desktop free preview 1.2.1329 - can't select text in editor window #4488

Comments

rgayler commented Mar 20, 2019 • edited

gtritchie commented Mar 21, 2019 • edited

rgayler commented Mar 21, 2019

gtritchie commented Mar 21, 2019

rgayler commented Mar 21, 2019

rgayler commented Mar 21, 2019

gtritchie commented Mar 21, 2019

gtritchie commented Mar 21, 2019

gtritchie commented Mar 21, 2019

jjallaire commented Mar 25, 2019

kevinushey commented Mar 25, 2019

kevinushey commented Mar 25, 2019

gtritchie commented Mar 25, 2019 • edited

kevinushey commented Mar 25, 2019 • edited

gtritchie commented Mar 25, 2019 • edited

jmcphers commented Mar 25, 2019

kevinushey commented Mar 25, 2019

jmcphers commented Mar 25, 2019

jmcphers commented Mar 27, 2019

rgayler commented Mar 27, 2019

ronblum commented Jun 7, 2019

rgayler commented Mar 20, 2019 •

edited

gtritchie commented Mar 21, 2019 •

edited

gtritchie commented Mar 25, 2019 •

edited

kevinushey commented Mar 25, 2019 •

edited

gtritchie commented Mar 25, 2019 •

edited