Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot view typed text in text field when renaming a file in files pane #4497

Closed
apreshill opened this issue Mar 22, 2019 · 13 comments
Closed
Assignees
Milestone

Comments

@apreshill
Copy link

@apreshill apreshill commented Mar 22, 2019

System details

RStudio Edition : <!-- Desktop or Server -->
RStudio Version : 1.2.1330
OS Version      :  Mojave 10.14.13 <- typo Mojave 10.14.3
R Version       : 

Steps to reproduce the problem

  1. Open a project in RStudio
  2. In the file viewer pane, check the box to select a file and click "Rename"
  3. Start typing the free text field that pops up

Describe the problem in detail

When I try to rename a file in the RStudio files pane, I cannot see the text as I type in the free text field. See screenshot, where you can see the cursor is to the right (I was typing "index" but no text is visible):

Screen Shot 2019-03-22 at 1 01 48 PM

Describe the behavior you expected

In previous versions I could always see the text as I typed in this field and I use this feature a lot so it is a new-ish issue.

@jmcphers
Copy link
Member

@jmcphers jmcphers commented Mar 22, 2019

This was previously reported in #2983 but should have been resolved. :-/ I can't repro locally, but I'm not sure what version of MacOS you're on (10.14.13 doesn't exist). What does sw_vers return for you in the Terminal?

I'm on:

ProductName:    Mac OS X
ProductVersion: 10.14.4
BuildVersion:   18E220a

Thanks for reporting!

@kevinushey
Copy link
Contributor

@kevinushey kevinushey commented Mar 22, 2019

Could you also please copy a screenshot of the Help -> About RStudio dialog box? See e.g.

Screen Shot 2019-03-22 at 1 19 48 PM

@kevinushey
Copy link
Contributor

@kevinushey kevinushey commented Mar 22, 2019

It looks like this reproduces specifically if you have a dark MacOS theme active, but a light RStudio editor theme set.

@ronblum
Copy link
Contributor

@ronblum ronblum commented Mar 22, 2019

Ah! I can reproduce with the dark theme on Mojave (10.14.4 beta). It's fine with the light theme. I believe this is a duplicate of the original, if I'm following it correctly.

@jmcphers jmcphers added this to the v1.2-patch milestone Mar 22, 2019
@ronblum ronblum added the bug label Mar 22, 2019
@jmcphers jmcphers added the macos label Mar 22, 2019
@apreshill
Copy link
Author

@apreshill apreshill commented Mar 22, 2019

Hi all,

Thanks for looking into it - sorry for the typo I'm on Mojave 10.14.3 and just installed the preview version of RStudio this morning based on the all staff email. I can confirm that I am using a "dark" theme:

Screen Shot 2019-03-22 at 2 07 12 PM

If I switch to "light", I can see the text:

Screen Shot 2019-03-22 at 2 07 48 PM

@coatless
Copy link

@coatless coatless commented Mar 22, 2019

Same issue 🙁

RStudio Edition :  Desktop 
RStudio Version : 1.2.1327
OS Version      :  macOS Mojave 10.14.3
R Version       :  3.5.3 (2019-03-11)

If this helps, on start up or creating a new window the dark theme is initially applied and, then, removed.

rstudio-startup-dark-theme

rstudio-pullout-window-dark-theme-issue

Only when launching a new window, c.f. the git client, does the dark theme not get overridden.

git-dark-theme-client-window

@kevinushey kevinushey self-assigned this Mar 28, 2019
@kevinushey
Copy link
Contributor

@kevinushey kevinushey commented Apr 1, 2019

Will be fixed in the v1.2 patch release with 6fa1ff0.

The fix involves backing out all attempts to change the titlebar color, as extra orchestration would be required to make sure this works with light vs. dark macOS themes, and we don't have time to do that safely for v1.2.

@jmcphers jmcphers closed this as completed Apr 3, 2019
@ronblum
Copy link
Contributor

@ronblum ronblum commented May 30, 2019

Verified in 1.2.1522 on MacOS 10.14.6. Checked four combinations (2 x 2) of MacOS theme and RStudio theme.

@coatless
Copy link

@coatless coatless commented May 31, 2019

@ronblum could this be reopened? I'm still getting the problem on 1.2.1522

@ronblum
Copy link
Contributor

@ronblum ronblum commented May 31, 2019

@coatless OK, will do. Just to confirm: is the background of the input field white or black?
white
black

@kevinushey We're seeing different results with 1.2.1522. For what it's worth, it works for me (MacOS 10.14.6 beta) and @rich-rstudio (MacOS 10.14), but not for @coatless (MacOS 10.14.3).

@ronblum ronblum reopened this May 31, 2019
@ronblum ronblum removed the verified label May 31, 2019
@coatless
Copy link

@coatless coatless commented May 31, 2019

@ronblum sorry. I wasn't on the latest preview build of Version 1.2.1522. This problem is fixed.

@ronblum
Copy link
Contributor

@ronblum ronblum commented May 31, 2019

@coatless Ah—great, and thanks for the update!

@jcolomb
Copy link

@jcolomb jcolomb commented May 20, 2020

I seem to have the same problem, only for the rename field.
macOS 10.14.1 (18B75)
RStudio Version 1.2.1335 (fresh upgrade via brew cask).
(background white)

seem to be specific to the "modern" theme:

could get rid of it changing the theme (Rstudio>preference> appearance
(went from modern to classic !!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants