Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

corrupt shortcut shown / used when binding keyboard shortcuts #6129

Closed
kevinushey opened this issue Jan 31, 2020 · 7 comments · Fixed by #6994
Closed

corrupt shortcut shown / used when binding keyboard shortcuts #6129

kevinushey opened this issue Jan 31, 2020 · 7 comments · Fixed by #6994

Comments

@kevinushey
Copy link
Contributor

@kevinushey kevinushey commented Jan 31, 2020

System details

RStudio Edition : Desktop [Open Source]
RStudio Version : 1.3.803
OS Version      : Windows 10 x64 (build 18362)
R Version       : R version 3.6.1 (2019-07-05)

Steps to reproduce the problem

Switch to a German (QWERTZ) keyboard layout, then try to change a keyboard shortcut using the Ctrl + Shift modifier keys. (For this example, I am trying to use Ctrl + Shift + V.)

Describe the problem in detail

Sometimes, an invalid key (square box) is shown.

Describe the behavior you expected

The key should be bound without issue.

Notes

The key reported on the associated Javascript event appears to be corrupt.

Screen Shot 2020-01-31 at 8 33 31 AM

Screen Shot 2020-01-31 at 8 33 37 AM

@kevinushey
Copy link
Contributor Author

@kevinushey kevinushey commented Jan 31, 2020

I can reproduce in Qt using the nano browser with Ctrl + Z and the default English keyboard layout.

@kevinushey
Copy link
Contributor Author

@kevinushey kevinushey commented Jan 31, 2020

Filed a Qt bug: https://bugreports.qt.io/browse/QTBUG-81783

@jmcphers
Copy link
Member

@jmcphers jmcphers commented Feb 20, 2020

It looks like this is going to need to be resolved on Qt's end, and even if they do commit a fix it's extremely unlikely we could bump Qt versions to pick it up in the 1.3 timeframe.

@jmcphers jmcphers removed this from the v1.3 milestone Feb 20, 2020
@AndriSignorell
Copy link

@AndriSignorell AndriSignorell commented May 22, 2020

This bug appeared to have been solved, but it is back (again?) with Version 1.3.959 - and still annoying. ;-)
Is there maybe a workaround?

@kevinushey
Copy link
Contributor Author

@kevinushey kevinushey commented May 22, 2020

Unfortunately, no -- there isn't currently any workaround that I'm aware of.

This has been fixed in the latest versions of Qt, so we'll hopefully pick up this fix when we next update Qt (not in v1.4, but likely the release following that).

That said, I think this is worth tracking for v1.4 in case we can find a simple workaround that we can implement for v1.4 (without requiring a new version of Qt).

@kevinushey kevinushey added this to the v1.4 milestone May 22, 2020
@jmcphers
Copy link
Member

@jmcphers jmcphers commented May 28, 2020

@kevinushey Any chance of a workaround in 1.3 patch? In my testing this is happening on any Ctrl-based keyboard shortcut on Windows which makes it very difficult to create any practical bindings.

Also just reported on the blog:

https://blog.rstudio.com/2020/05/27/rstudio-1-3-release/#comment-4930897957

On this new version, when I tried to change any shortcut to, for example "Run Selected Line" to 'Ctrl + R' it doesn't appear the "R" it appears a square: Ctrl + ☐. Looks like a bug

@R-Hannibal
Copy link

@R-Hannibal R-Hannibal commented Jun 24, 2020

Verified Fixed on: RStudio Version 1.3.1039, R Version 4.0.1, Windows 10 Desktop

Comparison testing between versions 1.3.959 and 1.3.1039, default English keyboard commands which were showing as Ctrl + Square symbol and non-functional are now setting and functioning correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants