Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find in Files "search these files" option doesn't work (1.3.820 preview edition only) #6230

Closed
jonathan-g opened this issue Feb 14, 2020 · 7 comments

Comments

@jonathan-g
Copy link

@jonathan-g jonathan-g commented Feb 14, 2020

System details

RStudio Edition : Desktop 
RStudio Version : Preview 1.3.820 "Middlemist Red" (bb7abc25, 2020-02-07) for Unknown OS
OS Version      : Windows 10
R Version       : 3.6.2

Steps to reproduce the problem

Open "Find in Files" and select an option for "Search these files"

Describe the problem in detail

If I choose any other option than "All Files" in "Search these files", Find in Files restores the option to "All Files" and searches all files.

This only happens with the preview edition. It does not happen with the current release.

Describe the behavior you expected

I expect to be able to choose other search options.

@melissa-barca

This comment has been minimized.

Copy link
Contributor

@melissa-barca melissa-barca commented Feb 14, 2020

Hi @jonathan-g I believe this issue was fixed under PR #6195 and is now part of the daily builds.

@jmcphers

This comment has been minimized.

Copy link
Member

@jmcphers jmcphers commented Feb 14, 2020

You can get a daily build here: https://dailies.rstudio.com/

@jmcphers jmcphers closed this Feb 14, 2020
@jonathan-g

This comment has been minimized.

Copy link
Author

@jonathan-g jonathan-g commented Feb 14, 2020

Hi, @jmcphers and @melissa-barca

Thanks for your quick attention to this.

I just downloaded and installed the latest daily (1.3.821) for Windows 10 and it shows the same faulty behavior: Whatever choice I make for "Search these files", the dialog returns to "All files".

However, I notice that the latest daily build for Windows is 2020-02-07, which is several days before the PR you reference. There are current (2020-02-14) dailies for MacOS and Ubuntu, but Windows is a week behind.

Maybe something is funny with your daily build pipeline for Windows?

@ronblum

This comment has been minimized.

Copy link

@ronblum ronblum commented Feb 14, 2020

@melissa-barca @jmcphers It's now working in RStudio Desktop 1.3.829 on MacOS. It looks like the MacOS build is from today (2/14/20), but the most recent Windows build, 1.3.821, is from 2/7/20—I think that was before the fix was picked up?

@gtritchie

This comment has been minimized.

Copy link
Contributor

@gtritchie gtritchie commented Feb 14, 2020

Yes, we are aware of the stalled Windows builds and are working on it.

@jonathan-g

This comment has been minimized.

Copy link
Author

@jonathan-g jonathan-g commented Feb 14, 2020

It's all good. I just wanted to check that you were aware of the issues.

I completely get that this is beta software and bugs are to be expected.

@jonathan-g

This comment has been minimized.

Copy link
Author

@jonathan-g jonathan-g commented Feb 15, 2020

This is to confirm that the latest daily build (1.3.839) fixes this bug for Windows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants
You can’t perform that action at this time.