Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update add Quarto to PATH #11396

Merged
merged 4 commits into from Jun 10, 2022
Merged

Update add Quarto to PATH #11396

merged 4 commits into from Jun 10, 2022

Conversation

jgutman
Copy link
Contributor

@jgutman jgutman commented Jun 9, 2022

Quarto is not being correctly added to the PATH on Windows platforms, which means that Shiny Quarto apps cannot be rendered, and also the R quarto package will not work.

Addresses #11291

Call Sys.setenv in R to set the PATH variable instead of core::system::setenv in C++.

Tested in Windows (Server 2019) and bundled Quarto is now correctly added to path, and Shiny Quarto docs can be rendered.

QA: For test plan, see details in #11291. Test with both bundled Quarto installation as well as separately installed Quarto CLI installed from quarto.org

@jgutman jgutman requested review from kevinushey and jjallaire Jun 9, 2022
{
core::system::addToPath(
string_utils::utf8ToSystem(s_quartoPath.getParent().getAbsolutePath()),
true
Copy link
Contributor Author

@jgutman jgutman Jun 9, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Previously, if there was a user installed path but prepend was set to false, Quarto was not added to the path at all. Instead, if prepend is false, we still want to modify the path, we'll just append rather than prepend it.

(Note that in my development version, it detects a user installed path but with prepend = false)

@jgutman jgutman requested a review from timtmok Jun 9, 2022
Copy link
Contributor

@timtmok timtmok left a comment

I'm ok with Quarto potentially being in the path twice.

@jgutman jgutman merged commit 70be39c into main Jun 10, 2022
@jgutman jgutman deleted the bugfix/quarto_windows_path branch Jun 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants