Skip to content

Fix rstudio Desktop compilation with GCC 4.7 #14

Merged
merged 1 commit into from Apr 17, 2012

2 participants

@JanMarvin

Fixes according to http://gcc.gnu.org/gcc-4.7/porting_to.html
Might break every other compiler :)

@jjallaire
RStudio member

Hi there, thanks for the request. 2 things:

1) I can't see what the actual change is to StringUtils.hpp -- definitely could be missing something but it looks like the utf8 functions were just moved rather than modified. If it is just a move if you could remove that file from the changelist that would be great.

2) To take a pull request we need either an individual or corporate contributor agreement (see: https://github.com/rstudio/rstudio/downloads). If you could send one of those we can pull the change (totally understand if this is a nuisance and you don't want to bother with it for a small change -- if you do this one then the next one will be easy :-)

Thanks,

J.J.

@JanMarvin

Hi,

To:
1) Function utf8Advance needs to be declared before its first use. Therefore it was moved. See the link above (section "Name lookup changes").

2) You have mail.

Have a nice day,
Marvin

Edit: woops :)

@jjallaire jjallaire merged commit 185292b into rstudio:master Apr 17, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.