Avoid early materialization of ALTREP objects #4210
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
LGTM! Do we need any UI-side changes so that the Environment pane reports something reasonable for these objects (when in Grid view)? |
kevinushey
reviewed
Jan 23, 2019
| } | ||
| public: | ||
| bool empty() const { return versionMajor_ != 0; } | ||
| bool empty() const { return versionMajor_ == 0; } |
Contributor
There was a problem hiding this comment.
Yikes! I guess we weren't ever really exercising this code path before?
Member
Author
There was a problem hiding this comment.
We were not! As far as I can tell this method was never used before.
Member
Author
We just report them as having no size -- the same thing we do for other "don't touch" objects (active bindings, uneval'ed promises, etc.) |
Contributor
|
Gotcha. I think that's fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, ALTREP objects (new in R 3.5.0) are fully materialized by RStudio's environment pane, since it calls
object.size()on them. This change protects these objects from premature evaluation by avoiding the environment pane's size/length inspection on objects with thealtflag set (indicating an ALTREP).Note that this does not protect the objects from any type of materialization at all; the first few elements will still be materialized by
str(), which we continue to call.Fixes #4171.