Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Save All command work across satellites #5274

Merged
merged 1 commit into from Aug 21, 2019

Conversation

@jmcphers
Copy link
Member

commented Aug 21, 2019

Currently, the Save All command, somewhat non-intuitively, saves only the files in the current window. This change makes it save all unchanged files in all windows.

We also currently make the Save All command enabled or disabled based on whether or not there are any unsaved targets in the current window. Aggregating this information correctly (and reacting to changes) across all windows is difficult to get right, so we take the conservative approach here of just leaving the command enabled if there are source windows open.

Fixes #5023.

@jmcphers jmcphers requested a review from gtritchie Aug 21, 2019
Copy link
Contributor

left a comment

One of those "I can't believe it didn't already do this" changes. Looks good.

@jmcphers jmcphers merged commit b86e763 into master Aug 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.