Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upA11y: fix focus selectors overriding focus-visible #5513
Merged
Conversation
|
LGTM! |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
adamconroy commentedOct 7, 2019
Fixes #5460
@MariaSemple Lmk if I'm doing anything wrong with the CSS here, it seems like doing CSS3 selectors can be a bit tricky with GWT's parser (https://stackoverflow.com/questions/3479636/how-to-get-gwt-cssresource-to-parse-not-selectors/7647867 couldn't get this to work though) so I pared down my changes to things that didn't throw errors.