Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A11y: fix focus selectors overriding focus-visible #5513

Merged
merged 2 commits into from Oct 7, 2019

Conversation

@adamconroy
Copy link
Contributor

adamconroy commented Oct 7, 2019

Fixes #5460

wqV0zgb

jPJRlNg

@MariaSemple Lmk if I'm doing anything wrong with the CSS here, it seems like doing CSS3 selectors can be a bit tricky with GWT's parser (https://stackoverflow.com/questions/3479636/how-to-get-gwt-cssresource-to-parse-not-selectors/7647867 couldn't get this to work though) so I pared down my changes to things that didn't throw errors.

@adamconroy adamconroy requested review from gtritchie and MariaSemple Oct 7, 2019
Copy link
Contributor

MariaSemple left a comment

LGTM!

Copy link
Contributor

gtritchie left a comment

LGTM

@adamconroy adamconroy merged commit 42cdf08 into master Oct 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.