Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

guard against recursive error pages #5571

Merged
merged 1 commit into from Oct 17, 2019

Conversation

@kevinushey
Copy link
Contributor

kevinushey commented Oct 16, 2019

This avoids an issue where, if an error is shown while attempting to load an error page, a recursive cascade of errors windows will be popped up.

While this doesn't fix the underlying issue, it's still worth guarding against even post-fix.

Copy link
Member

jmcphers left a comment

This is fine, but ultimately I think we'll have to find a way to plumb the load failure into loadFinished so we can distinguish between a failure to load the IDE and a failure to load the error page itself.

@jmcphers jmcphers merged commit 510a901 into master Oct 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.