Add parameter to EditingTarget.onActivated indicating whether it's being activated for user interaction #6523
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an argument to the
EditingTarget.onActivated()
method that indicates whether the editor tab is being activated for the purpose of user interaction (during startuponActivated()
is called for each tab being restored irrespective of whether it will actually end up active at the end of startup).The motivation is that panmirror does some potentially expensive (depending on the platform) work at startup (calls pandoc twice). On Linux/OSX these calls take sub 10ms however on Windows they can take 100ms+. If a user has dozens of tabs w/ panmirror to be restored, the cost of doing panmirror initialization eagerly could become prohibitive. With this change we can defer this work until the user is actually going to interact with the document.
I could have "fixed"
onActivated()
to not be called during IDE tabset restoration, however I'm sure we have implicit dependencies on this elsewhere and unwinding them seems risky / cost prohibitive.