Download and/or convert theme as appropriate #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinushey
approved these changes
Dec 11, 2018
R/themes.R
Outdated
| # If the path appears to be a URL, download it. | ||
| if (grepl("^https?:", themePath)) { | ||
| # Give the downloaded filename the same name and extension as the original. | ||
| parts <- strsplit(themePath, "/", fixed = TRUE)[[1]] |
There was a problem hiding this comment.
Nit: I think basename() would still work fine for URLs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small change motivated by theme installation instructions beginning to appear in the wild, e.g.:
https://github.com/gadenbuie/yule-rstudio
https://github.com/batpigandme/night-owlish
Ideally the "install and apply my theme" code snippet featured in these repos would be a single line of R code. This change makes that possible by adding some logic to the
addThemeAPI wrapper:After the change, you can download, install, and apply a theme in a single step: