Added shared footnotes to elsevier_article() #255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… share the same footnote (e.g. "contributed equally"); updated the corresponding skeleton to demonstrate how to use a shared footnote
yihui
approved these changes
Oct 31, 2019
|
Good point. I had started with that, but then wasn't sure if there would be some confusion between author.footnote and footnote.code (since author.affiliation links to address.code). I just checked locally and that doesn't appear to be a problem. Do you want to me to submit a new pull request? |
…n elsevier_article()
|
I think this is ready to be merged. |
yihui
approved these changes
Nov 14, 2019
yihui
added a commit
that referenced
this pull request
Nov 14, 2019
|
What is about multiple footnotes for one author? E.g. the corresponding author contributed equally with another author? |
|
@wulms That's a good observation. I had assumed it worked the same way as with affiliations, but it clearly doesn't. Should make an issue for this. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the template for elsevier_article to allow for two authors to share the same footnote (e.g. "these authors made equal contributions") and updated the corresponding skeleton to demonstrate how to use a shared footnote. To do this, I mimicked the style of shared affiliations. (This is my first pull request to an RStudio repo. Any feedback you have for me would be much appreciated!)