Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Capture upstart failures to start. #133

Merged
merged 1 commit into from Jul 2, 2015

Conversation

trestletech
Copy link
Contributor

No description provided.

@aronatkins
Copy link
Contributor

The goal is to prevent respawn on startup failures, correct? Could we use a separate exit code for situations where we are unable to properly initialize the web and admin interfaces? If so, we could configure normal exit with those codes.

A bit of help found here: http://askubuntu.com/questions/62434/why-does-upstart-keep-respawning-my-process

and the upstart docs: http://upstart.ubuntu.com/wiki/Stanzas#normal_exit

@aronatkins
Copy link
Contributor

Maybe what I've proposed is an abuse of normal exit. The exit in your post-stop means a startup failure takes how long to resolve compared to before this PR?

@trestletech
Copy link
Contributor Author

Looks like a custom exit code form the pgrep and a normal exit didn't change anything. I think the main process (shiny server) would need to exit with a particular code to avoid being respawned.

I think this is as good as we can do right now.

trestletech added a commit that referenced this pull request Jul 2, 2015
@trestletech trestletech merged commit 9fbfd6a into master Jul 2, 2015
@trestletech trestletech deleted the jeff/report-upstart-failure branch July 2, 2015 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants