New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use HTTPS for Google Fonts on error page #322

Merged
merged 1 commit into from Oct 23, 2017

Conversation

Projects
None yet
2 participants
@brooklynbagel
Contributor

brooklynbagel commented Oct 11, 2017

tempates/directoryIndex.html has been using HTTPS for getting Google Fonts for several years, see commit, however the error page does not. This has caused Firefox (56.0 on Mac OS X) to either not load the fonts or consider my connection to the server to be insecure. This should resolve the issue and the inconsistency.

@jcheng5 jcheng5 merged commit e77d511 into rstudio:master Oct 23, 2017

@jcheng5

This comment has been minimized.

Show comment
Hide comment
@jcheng5

jcheng5 Oct 23, 2017

Member

Thank you!

Member

jcheng5 commented Oct 23, 2017

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment