Conversation
Member
Author
|
I'm going to merge this, but feel free to leave comments here and I'll follow up. |
schloerke
reviewed
Jan 17, 2025
Collaborator
schloerke
left a comment
There was a problem hiding this comment.
Thank you for making it opt-in!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a composite workflow
rstudio/shiny-workflows/format-r-codethat is included into theroutineworkflow to format R code withair.This composite workflow can be used anywhere with
In the routine workflow, I've put the formatting step behind
inputs.format-r-code, which isfalseby default. To turn it on:That lets us opt-in slowly initially or eventually we can change the default value and start formatting everything.
The composite workflow has additional inputs:
version(default:latest) - which version ofairto use so that we could pin to a specific version.check(default: false) - when"true"callsair format --check, which exits with a non-zero status if any files change, no changes are committedpath(default:.) - paths passed toair format ..., can be files or directories, e.g.R instto format R files inR/andinst/only. The current default formats all R files in the repo (aggressive but useful).I've used this workflow in bslib as a demo: rstudio/bslib#1167