From c4dcf405bb02f0082acbd4ff0e65447c319b47e0 Mon Sep 17 00:00:00 2001 From: Barret Schloerke Date: Tue, 25 Aug 2020 11:49:22 -0400 Subject: [PATCH] Fix reactiveValuesToList reactlog label (#3017) Co-authored-by: Barret Schloerke Co-authored-by: Winston Chang --- NEWS.md | 4 ++++ R/graph.R | 4 ++-- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/NEWS.md b/NEWS.md index afc6736d3a..a519d4e93e 100644 --- a/NEWS.md +++ b/NEWS.md @@ -2,6 +2,8 @@ shiny 1.5.0.9000 ================ +## Full changelog + ### Accessibility * Added [bootstrap accessibility plugin](https://github.com/paypal/bootstrap-accessibility-plugin) under the hood to improve accessibility of shiny apps for screen-reader and keyboard users: the enhancements include better navigations for alert, tooltip, popover, modal dialog, dropdown, tab Panel, collapse, and carousel elements. (#2911) @@ -22,6 +24,8 @@ shiny 1.5.0.9000 * Closed #2972: `runExample()` now supports the `shiny.port` option (thanks to @ColinFay). (#2982) +* `reactiveValuesToList()` will save its `reactlog` label as `reactiveValuesToList()` vs `as.list()` (#3017) + ### Bug fixes * Fixed #2859: `renderPlot()` wasn't correctly setting `showtext::showtext_opts()`'s `dpi` setting with the correct resolution on high resolution displays; which means, if the font was rendered by showtext, font sizes would look smaller than they should on such displays. (#2941) diff --git a/R/graph.R b/R/graph.R index d43bfe8b92..22d281468a 100644 --- a/R/graph.R +++ b/R/graph.R @@ -179,10 +179,10 @@ RLog <- R6Class( paste0("names(", reactId, ")") }, asListIdStr = function(reactId) { - paste0("as.list(", reactId, ")") + paste0("reactiveValuesToList(", reactId, ")") }, asListAllIdStr = function(reactId) { - paste0("as.list(", reactId, ", all.names = TRUE)") + paste0("reactiveValuesToList(", reactId, ", all.names = TRUE)") }, keyIdStr = function(reactId, key) { paste0(reactId, "$", key)