htmlDependency package parameter requires `htmltools` 0.3.6 #2256

colearendt · 2018-11-11T19:59:05Z

Lines 1550 to 1554 in 5e2b40d

    
           htmlDependencies(iconTag) <- htmlDependency( 
        
             "font-awesome", "5.3.1", "www/shared/fontawesome", package = "shiny", 
        
             stylesheet = c( 
        
               "css/all.min.css", 
        
               "css/v4-shims.min.css"

We should probably update the dependency on htmltools to be version >= 0.3.6, because per this issue, it seems that htmltools 0.3.5 does not have the package parameter.

shiny/DESCRIPTION

Line 73 in 5e2b40d

htmltools (>= 0.3.5),

The text was updated successfully, but these errors were encountered:

colearendt mentioned this issue Nov 11, 2018

fix dependency version since htmltools 0.3.6 is used #2257

Merged

schloerke added Priority: Low Effort: Low Type: Bug 🐛 and removed Priority: Low labels Nov 15, 2018

jcheng5 closed this as completed in #2257 Nov 15, 2018

htmlDependency package parameter requires htmltools 0.3.6 #2256

htmlDependency package parameter requires htmltools 0.3.6 #2256

Comments

colearendt commented Nov 11, 2018

htmlDependency package parameter requires `htmltools` 0.3.6 #2256

htmlDependency package parameter requires `htmltools` 0.3.6 #2256