New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give each ReactiveVal separate dependents #1712

Merged
merged 2 commits into from May 22, 2017

Conversation

Projects
None yet
2 participants
@wch
Collaborator

wch commented May 22, 2017

This fixes #1710. Previously, all ReactiveVal objects shared the same set of dependents (!!).

The dependents <- Dependents$new() needs to be assigned in the initialize method for each one to have its own set of dependents.

@wch wch added the review label May 22, 2017

@wch wch requested a review from jcheng5 May 22, 2017

@jcheng5 jcheng5 merged commit 852c000 into master May 22, 2017

4 checks passed

continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@jcheng5 jcheng5 deleted the wch-fix-reactiveval branch May 22, 2017

@jcheng5 jcheng5 removed the review label May 22, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment