Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #2385: R Markdown documents containing subapps not rendering properly #2386

Merged
merged 4 commits into from Apr 18, 2019

Conversation

jcheng5
Copy link
Member

@jcheng5 jcheng5 commented Apr 13, 2019

@jcheng5 jcheng5 force-pushed the joe/bugfix/subapp-routing branch from 5032ba1 to b01266a Compare Apr 13, 2019
R/server.R Show resolved Hide resolved
Untitled.Rmd Outdated Show resolved Hide resolved
hi.html Outdated Show resolved Hide resolved
NEWS.md Outdated Show resolved Hide resolved
@jcheng5 jcheng5 force-pushed the joe/bugfix/subapp-routing branch from b01266a to 1b8d822 Compare Apr 15, 2019
@jcheng5
Copy link
Member Author

@jcheng5 jcheng5 commented Apr 15, 2019

Heh, whoops. This is why it's a bad idea to make PRs late at night...

@jcheng5 jcheng5 requested a review from wch Apr 15, 2019
R/server.R Show resolved Hide resolved
@jcheng5 jcheng5 requested a review from wch Apr 17, 2019
@jcheng5
Copy link
Member Author

@jcheng5 jcheng5 commented Apr 18, 2019

@wch bump

wch
wch approved these changes Apr 18, 2019
@jcheng5 jcheng5 merged commit 36373ba into v1.3-patch Apr 18, 2019
4 checks passed
@wch wch deleted the joe/bugfix/subapp-routing branch Apr 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants