Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak runTests() output format #2764

Merged
merged 19 commits into from Apr 6, 2020
Merged

Tweak runTests() output format #2764

merged 19 commits into from Apr 6, 2020

Conversation

@alandipert
Copy link
Contributor

@alandipert alandipert commented Feb 19, 2020

Currently runTests() returns a structure with a member that varies in type between a result value, NA, or an error object.

This PR normalizes the format of the return value of runTests() at the cost of some redundancy. The goal is to simplify consumption by downstream tools interested in test outcomes.

Dev TODO

  • Add test(s)
  • Improve documentation
  • Add to NEWS.md
@alandipert alandipert requested review from wch and schloerke Feb 25, 2020
@alandipert alandipert marked this pull request as ready for review Feb 25, 2020
@alandipert
Copy link
Contributor Author

@alandipert alandipert commented Feb 25, 2020

CI is currently failing with the following R CMD check NOTE:

* checking installed package size ... NOTE
  installed size is 11.1Mb
  sub-directories of 1Mb or more:
    R     1.6Mb
    www   8.3Mb
@schloerke
Copy link
Collaborator

@schloerke schloerke commented Feb 25, 2020

That is a standard/consistent NOTE for shiny

R/test.R Outdated Show resolved Hide resolved
R/test.R Show resolved Hide resolved
NEWS.md Show resolved Hide resolved
R/test.R Show resolved Hide resolved
R/test.R Show resolved Hide resolved
@wch
wch approved these changes Apr 6, 2020
@wch wch merged commit ecd7c76 into master Apr 6, 2020
1 of 5 checks passed
1 of 5 checks passed
continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
continuous-integration/travis-ci/push The Travis CI build could not complete due to an error
Details
continuous-integration/appveyor/branch AppVeyor build failed
Details
continuous-integration/appveyor/pr AppVeyor build failed
Details
license/cla Contributor License Agreement is signed.
Details
@wch wch deleted the runTests-aggregate branch Apr 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.