Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upmoduleServer/testServer overhaul #2807
Merged
Conversation
Closed
alandipert
changed the title
wch
merged commit b709b53
into
master
3 of 5 checks passed
3 of 5 checks passed
continuous-integration/travis-ci/push
The Travis CI build could not complete due to an error
Details
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
This PR aligns the feature formerly known as "integration testing" with the new
moduleServer()function and usage patterns.Changes
Previously, the integration testing feature consisted of two entrypoints:
testModule()andtestServer(). Now, there's only one entrypoint,testServer().testServer()can be used to test either the server functions in established Shiny apps, or module functions.In addition to the consolidation of these functions, there is a slight semantic change corresponding to the change in definition of a Shiny module. Previously, the environment captured from within module functions was used to mask the surrounding dynamic environment of the
testServer(). The combination of the module's dynamic environment mask and the environment surrounding the call totestServer()defined the environment in which theexprargument totestServer()was evaluated.Now, because "new-style" modules involve at least two functions -- and two environments of interest, with respect to testing -- these two function environments are combined, with the inner-most environment taking precedence. The new semantics are demonstrated in
tests/testthat/test-test-server-scope.R.