[pagedown] use Google Chrome instead of Chromium #291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RLesur
changed the title
kippandrew
approved these changes
Apr 20, 2021
jforest
approved these changes
Apr 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This PR proposes to install Chrome instead of Chromium to support
pagedown::chrome_print().Until bionic, Chromium is available as a deb file. However since disco, Chromium is only distributed as a snap package but
snapddoes not work in containers.The most simple workaround is to use Chrome instead of Chromium.
FYI, 8a47293 re-introduces a functional test that was removed by 3bdedd1 (#290 would have been detected by such a test).
Tell me whether you prefer that I remove it again.
Fix #290