Collapse button triggers shown and hidden events. Closes #42
- Loading branch information
- +1 −0 inst/AdminLTE/README-shiny-mods.md
- +9 −0 inst/AdminLTE/app.js
- +1 −1 inst/AdminLTE/app.min.js
- +1 −1 inst/AdminLTE/app.min.js.map
| @@ -1,4 +1,5 @@ | ||
| This branch of AdminLTE contains the following changes from the stock version, to make it work better with Shiny. | ||
|
|
||
| * Attached collapse click event handler to document, instead of to each collapse button. This is the same fix as https://github.com/almasaeed2010/AdminLTE/pull/304; if that is merged, then it should be possible to go to the stock version. Also see https://github.com/rstudio/shinydashboard/issues/17 for a test app. | ||
| * The box collapse function triggers 'shown' and 'hidden' events, so that Shiny knows when outputs are visible or not. See https://github.com/rstudio/shinydashboard/issues/42 for a test app. | ||
| * In AdminLTE.css, the fonts are fetched from the local host, instead of from Google fonts. |
This comment has been minimized.
@wch, I see that there's an AdminLTE fork with shiny-mods branch. However that shiny-mods doesn't contain the changes that you made here.
It would be really helpful for me to track these changes if you pushed them to that branch on your AdminLTE fork. Thanks!
This comment has been minimized.
See https://github.com/rstudio/AdminLTE/tree/shiny-mods.
This comment has been minimized.
@wch, I did, I'm referring to it exactly, and it does not have this change.
This comment has been minimized.
Shoot, you're right. That branch hasn't been kept up-to-date. I think the relevant changes are only in the shinydashboard repository, so unfortunately there isn't a really easy way to keep track of them right now.