Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure bookmarking works #179

Closed
wch opened this issue Jan 26, 2017 · 2 comments
Closed

Make sure bookmarking works #179

wch opened this issue Jan 26, 2017 · 2 comments
Assignees

Comments

@wch
Copy link
Contributor

@wch wch commented Jan 26, 2017

Features to check:

  • Selected tab in menuItem and menuSubItem is saved. (May be related to #128.)
  • Sidebar menuItem expanded state is saved.
@wch wch added the targeted label Jan 26, 2017
@bborgesr
Copy link
Contributor

@bborgesr bborgesr commented Feb 23, 2017

In addition:

  • Sidebar expanded/collapsed state

So, in summary, we have to add "bookmarkability" for:

  • sidebar expanded/collapsed state
  • menuItems expanded/collapsed state
  • menuItem (or subMenuItem) that is selected/active

Possible solutions:

  • give inputId, like tabsetPanel (gives bookmarkability by default). This would also address #114 (and allow us to close the corresponding PR, #128)
  • create new function(s) to be used inside onBookmark and onRestore (no default bookmarkability)

Also:

  • make sure this works with a dynamically generated sidebarMenu
@bborgesr bborgesr self-assigned this Feb 23, 2017
@bborgesr bborgesr mentioned this issue Apr 25, 2017
@bborgesr
Copy link
Contributor

@bborgesr bborgesr commented May 17, 2017

Closed in #199

@bborgesr bborgesr closed this May 17, 2017
@bborgesr bborgesr removed the in progress label May 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.