Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFixes #176. #182
Merged
Fixes #176. #182
Conversation
|
This is now specific only to Shiny action buttons and links. Also, the NEWS entry is improved. @wch, ready to merge? |
dmpe
added a commit
to dmpe/shinydashboard
that referenced
this pull request
Mar 25, 2017
…iny action buttons and links some margin space. (rstudio#182)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Made buttons look good on the sidebar by giving buttons and anchor tags some margin space.
I didn't make this specific to Shiny action buttons and action links. Rather, all button and anchor tags inside the sidebar will have this rule applied to them. I think this is what we want, right?