Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #176. #182

Merged
merged 3 commits into from Feb 15, 2017
Merged

Fixes #176. #182

merged 3 commits into from Feb 15, 2017

Conversation

@bborgesr
Copy link
Contributor

@bborgesr bborgesr commented Jan 31, 2017

Made buttons look good on the sidebar by giving buttons and anchor tags some margin space.

I didn't make this specific to Shiny action buttons and action links. Rather, all button and anchor tags inside the sidebar will have this rule applied to them. I think this is what we want, right?

@bborgesr
Copy link
Contributor Author

@bborgesr bborgesr commented Feb 15, 2017

This is now specific only to Shiny action buttons and links. Also, the NEWS entry is improved. @wch, ready to merge?

@bborgesr bborgesr merged commit 02c505c into master Feb 15, 2017
4 checks passed
4 checks passed
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@bborgesr bborgesr removed the in progress label Feb 15, 2017
@bborgesr bborgesr deleted the barbara/buttons branch Feb 15, 2017
dmpe added a commit to dmpe/shinydashboard that referenced this pull request Mar 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
You can’t perform that action at this time.