Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sidebar complete showing/hiding on mobile #204

Merged
merged 2 commits into from
Apr 21, 2017
Merged

Fix sidebar complete showing/hiding on mobile #204

merged 2 commits into from
Apr 21, 2017

Conversation

bborgesr
Copy link
Contributor

@bborgesr bborgesr commented Apr 21, 2017

Fixes #127 and fixes #177: previously, if dashboardSidebar() was called with an explicit width parameter, mobile rendering would look weird (the sidebar wouldn't completely disappear when it was collapsed, and content in the dashboard body would be hidden under the still-visible sidebar).

Small example:

library(shiny)
library(shinydashboard)
shinyApp(
    ui = dashboardPage(
        dashboardHeader(),
        dashboardSidebar(width = "150px"),
        dashboardBody("Hello world"),
        title = "Dashboard example"
    ),
    server = function(input, output) { }
)

…r is passed to dashboardSidebar() (fixes #177 and fixes #127)
@wch wch merged commit 6fdc564 into master Apr 21, 2017
@wch wch deleted the barbara/phone branch April 21, 2017 15:34
@wch wch removed the in progress label Apr 21, 2017
bborgesr added a commit that referenced this pull request Apr 21, 2017
…r is passed to dashboardSidebar() (fixes #177 and fixes #127) (#204)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sidebar width property screws up mobile rendering Sidebar on Phones
2 participants