Move appveyor to GHA #22

cderv · 2022-04-14T19:55:50Z

This aims to replace appveyor build.

I am opening this PR so that you can have a look at the change and give some feedback. Here is the details:

Current proposal:

We split the process into 3 workflows:

One for building full TeX Live bundle on all OS which will be triggered when the other daily builds succeed in tinytex repo
One to schedule monthly for the dated monthly release based on last daily with possibility to do a patch release manually if necessary
One to build and publish the Choco package and that would be called from within the monthly one once the new monthly tag is created and choco spec modified.

So basically the workflow would be :

Daily builds are done in the tinytex repo and a new daily release is created with new assets
When this is done sucessfully, it will trigger the daily workflow here to build the daily full bundle and it will update the daily release by adding the missing assets.
Every first of the month, the monthly workflow would run and will download every assets of the last daily release.
It will keep the TinyTeX bundles and adds a vYYYY-MM to the name.
The choco configuration will be updated and a new tag will be created.
A new release is created with all the assets
As last step, the workflow to update choco package will be triggered to build and publish the package.

I have tested all this in my fork, hence the reference to my repos in this PR. I left it as is in the draft PR and modified if everything is ok. Also, the choco publishing if deactivated for now. Setting the API KEY CHOCO_KEY in the repo secret will be necessary

Test of releases are here: https://github.com/cderv/tinytex-releases/releases

Also some .sh files have been removed - are you using them elsewhere ?

A few questions:

How do we want to handle the fact that daily version will not have TinyTeX-2 until it is build here and added to the daily release ?
- Otherwise we could add it directly in the other workflow but it would take longer everyday to create the new daily. Here is some idea of the timing from a build 16min for Linux, 37min for Mac and 57min on Windows (https://github.com/cderv/tinytex-releases/actions/runs/2169025650)
- Or we could deploy the previous bundle when create the new daily release so that files are there, but they would be updated later with the workflow here.
Do we want to publish a new choco package when doing a patch version ?
Was this --source argument necessary ?
https://github.com/yihui/tinytex-releases/blob/ba3b3d33901085f01f639857da1aa2e0b20a0f99/appveyor.yml#L67
I modified it so that we only test the built source package. Do I need to revert back ?

I did not test to install one of the bundle yet, but I think it will work. I'll do that next week.

This reverts commit 9c8f669151e22f7ebaddb887714762577993d153.

otherwise the commit of the workflow that triggered workflow_call is used

This reverts commit da6bee1.

naveen521kk · 2022-04-15T04:59:32Z

I modified it so that we only test the built source package. Do I need to revert back ?

Looks good. Actually, the additional source to their community repository would be required if the package had any dependencies; but it doesn't have so it should work with just ..

.github/workflows/build.yaml

Co-authored-by: Yihui Xie <xie@yihui.name>

cderv · 2022-04-21T14:36:08Z

@yihui one question: Build TinyTeX-2 version, so the full scheme, is just a matter of running tlmgr install scheme-full, then creating the bundle ?

I mean it could be in fact a step in our existing daily workflow in https://github.com/yihui/tinytex/blob/main/.github/workflows/build.yaml ?

Build TinyTeX-0
Build TinyTeX-1
Build TinyTeX
Build TinyTeX-2
Build tinytex
Build installer-unix on Ubuntu only
Build regex bundle only once (not OS dependant)

Am I right ?

I am asking as I reworked the daily workflow using the new gh release edit feature, and I believe we could merge everything there for daily release as discussed. I want to be sure I got it right.

Can you confirm ? Thanks!

yihui · 2022-04-21T16:39:36Z

I mean it could be in fact a step in our existing daily workflow in https://github.com/yihui/tinytex/blob/main/.github/workflows/build.yaml ?

Yes, it could be a step there. I think that will be simpler.

cderv · 2022-04-21T18:54:05Z

Yes, it could be a step there. I think that will be simpler.

Yes it definitely will be. I am taking more time that I thought on this, but once that will be in place, it should work for a long time (hopefully). I am almost there! I need gh CLI 2.8 on windows runner now 😅 too recent

cderv · 2022-04-25T09:47:31Z

I have now moved the daily build of scheme-full in the tinytex repo with other daily build version.

This repo will now only contains monthly build, and patch version builds, with chocolatey packaging and publishing.

I'll merge this one as soon as the other is merged.

yihui · 2022-04-25T13:59:07Z

.github/workflows/monthly-release.yaml

+      - name: Current tag to target
+        run: |
+          # Are we making a patch version ? 
+          patch_version=${{ github.event.inputs.patch_version }}


Previously on AppVeyor, I was using an env var TINYTEX_PATCH_VERSION to set the patch version number. When I need to make a patch release, I manually set this env var and trigger the build (and unset the env var after the build is done). I wonder how I should make the patch release now?

I guess using workflow_dispatch events https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#workflow_dispatch, though it needs to be configured first.

Yes the idea would be through the workflow_dispatch event configure here:
https://github.com/yihui/tinytex-releases/blob/e08ca8ba1ff0e68331af804ae35ed61be2bac46a/.github/workflows/monthly-release.yaml#L3-L8
There is a patch_version input that can be set.

Two ways to trigger this:

Either using gh CLI, gh workflow run passing key value pair with a value of the day. Ex with today -f patch_version=25 which will creaye 2022.04.25

gh workflow run monthly-release.yaml -f patch_version=25

Either using the menu in the Action pane - example in my fork

By default nothing is set = no patch version. If filled, then a patched version will be made.

More docs:

https://github.blog/changelog/2020-07-06-github-actions-manual-triggers-with-workflow_dispatch/

https://docs.github.com/en/actions/managing-workflow-runs/manually-running-a-workflow

Oh great! Thanks for teaching me this!

if manually trigger, then we use the value from the inputs which default to false. For automated monthly release with deploy all the time

cderv · 2022-04-25T15:02:16Z

I have added a better description of what value to set, and also a new inputs for not deploying to choco if we want to build a patch version without deploying

yihui · 2022-04-25T15:21:04Z

Sounds good!

cderv · 2022-04-25T16:42:39Z

I ran the new workflow on tinytex to build a daily manually and this is working https://github.com/yihui/tinytex/actions/runs/2220702807 published the new https://github.com/yihui/tinytex-releases/releases

I'll merge this and try a patch release to check it is working

cderv · 2022-04-25T16:47:02Z

Can you give me correct access also in this repo ?
For whatever reason I don't see an Action tab... Maybe it needs to be activated ? I found the url works though: https://github.com/cderv/test-actions/action

cderv · 2022-04-25T17:21:49Z

And it works ! 🎉

See https://github.com/yihui/tinytex-releases/actions/runs/2221722638

I did the final test in "master" as it was easier to check bu reverted the tag, test patch release and commit.

Everything is good for next month !

yihui · 2022-04-25T18:01:06Z

Can you give me correct access also in this repo ?
For whatever reason I don't see an Action tab... Maybe it needs to be activated ?

I don't know why that happens, but I don't have an option to change your role in this repo or activate the Actions tab specifically. Can you see the Actions tab now?

Everything is good for next month !

Perfect! Thanks!

cderv · 2022-04-25T18:19:39Z

I don't know why that happens, but I don't have an option to change your role in this repo or activate the Actions tab specifically. Can you see the Actions tab now?

No I don't see it. That is odd... I'll look on the web for information. I can access the tab using url directly so I am not blocked

yihui · 2022-04-25T18:29:30Z

That's really odd. I tried other web browsers and I was able to see the tab no matter if I'm logged in or not.

cderv · 2022-04-25T18:36:33Z

Got an idea. I'll check something ...

cderv · 2022-04-25T19:12:06Z

Yeah I think this is an issue in Refined GitHub extension. I'll fill an issue there. Sorry for the trouble

cderv · 2022-05-02T10:51:33Z

I had to tweak a little the PR in 507893d and 170c508 so that the publishing to chocolatey works.

I manually triggered this month build also because schedule was for next mont in fact. Starting in JUNE, this should all work fine automatically

yihui · 2022-05-02T14:01:51Z

Sounds good. Thank you!

cderv added 30 commits April 14, 2022 21:56

to have a new ref in main

dc286ff

First try on build for Linux

3a64c5a

Configure git

2e6a869

Try a full run

e0ddfa6

It should work with Github Token

2cc63a0

We need to push the commit and the tag

96000c5

if tag exist it should be ignore

2d2eb0d

Echo more to find the isue

9d02d44

We need to fetch everything to get the tags

0619bd9

add more precise comment

bbf1b30

Revert "Separate choco package build & publish workflow"

1822a59

This reverts commit 9c8f669151e22f7ebaddb887714762577993d153.

Separate into 3 workflows

fa608e9

should be daily release

79ac45b

Update names of workflow

d5cd747

reactivate workflow

2506c24

directory needs to be created

aa17804

Try this way

353d5a0

Create the dir

a0a49ad

run the cho workflow differently

6ed1b11

correcly call a reusable workflow

0518eb0

remove unused files

d63168b

Try installing only for local to test the package

263e2f9

Improve logging message

fa7bf7e

use specific ref to get latets commit

2eb9d60

otherwise the commit of the workflow that triggered workflow_call is used

Don't forget to rename file and update choco spec after

b099bcf

Improve log by grouping lines

943aa4a

Remove duplicated v

020abcc

Revert "Improve log by grouping lines"

355cad2

This reverts commit da6bee1.

don't include regex bundle

e64b1b5

Separate step for cleaner log

5dc7e56

naveen521kk reviewed Apr 15, 2022

View reviewed changes

.github/workflows/build.yaml Outdated Show resolved Hide resolved

cderv and others added 3 commits April 20, 2022 14:47

Apply suggestions from code review

f459068

Co-authored-by: Yihui Xie <xie@yihui.name>

Simplify and use curl instead of powerhsell method

9d08fc5

rename workflow

9f6ae77

Daily builds are now in yihui/tinytex workflow

64a3504

cderv mentioned this pull request Apr 25, 2022

Building daily full bundle TinyTeX-2 on GHA rstudio/tinytex#369

Merged

Prepare file for merging

e08ca8b

cderv marked this pull request as ready for review April 25, 2022 10:00

yihui reviewed Apr 25, 2022

View reviewed changes

cderv added 2 commits April 25, 2022 16:45

Update description for menu when using workflow_dispatch

ad45ee7

Add an input in manual trigger for choco deploy.

8ad2b4b

if manually trigger, then we use the value from the inputs which default to false. For automated monthly release with deploy all the time

cderv merged commit 40fc5ff into master Apr 25, 2022

cderv deleted the build-gha branch April 25, 2022 16:44

Uh oh!

Move appveyor to GHA #22

Move appveyor to GHA #22

Uh oh!

Conversation

cderv commented Apr 14, 2022

Uh oh!

naveen521kk commented Apr 15, 2022

Uh oh!

Uh oh!

cderv commented Apr 21, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

yihui commented Apr 21, 2022

Uh oh!

cderv commented Apr 21, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cderv commented Apr 25, 2022

Uh oh!

yihui Apr 25, 2022

Choose a reason for hiding this comment

Uh oh!

naveen521kk Apr 25, 2022

Choose a reason for hiding this comment

Uh oh!

cderv Apr 25, 2022

Choose a reason for hiding this comment

Uh oh!

yihui Apr 25, 2022

Choose a reason for hiding this comment

Uh oh!

cderv commented Apr 25, 2022

Uh oh!

yihui commented Apr 25, 2022

Uh oh!

cderv commented Apr 25, 2022

Uh oh!

cderv commented Apr 25, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cderv commented Apr 25, 2022

Uh oh!

yihui commented Apr 25, 2022

Uh oh!

cderv commented Apr 25, 2022

Uh oh!

yihui commented Apr 25, 2022

Uh oh!

cderv commented Apr 25, 2022

Uh oh!

cderv commented Apr 25, 2022

Uh oh!

cderv commented May 2, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

yihui commented May 2, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

cderv commented Apr 21, 2022 •

edited

Loading

cderv commented Apr 21, 2022 •

edited

Loading

cderv commented Apr 25, 2022 •

edited

Loading

cderv commented May 2, 2022 •

edited

Loading