-
Notifications
You must be signed in to change notification settings - Fork 121
Building daily full bundle TinyTeX-2 on GHA #369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
that would make all the build time wasted
cderv
commented
Apr 25, 2022
cderv
commented
Apr 25, 2022
yihui
approved these changes
Apr 25, 2022
Contributor
yihui
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thank you!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adapt the current daily build workflow so that we are building the full version in the same workflow here and not in yihui/tinytex-releases anymore.
This is part of the work to migrate from Appveyor (rstudio/tinytex-releases#22).
Monthly release and chocolatey packaging are still done in tinytex-releases repo.
This will increase the build time of the daily release to 1 or 2hours, but that is reasonable.
We are also using new version for
ghCLI which allow us to undraft a draft release. New workflow is nowDoing the drafting part before deleting will allow us to undraft manually, if there is an issue in the process of undrafting.
It is working ok in my fork (https://github.com/cderv/tinytex/actions/runs/2208840019) - Total time is 1H for the all workflow.
Is there anything that question you ? Does it seems ok to you ?