Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rough out Python sections #5

Merged
merged 11 commits into from May 11, 2022
Merged

Rough out Python sections #5

merged 11 commits into from May 11, 2022

Conversation

juliasilge
Copy link
Member

@isabelizimm I got this started and would love for you to make changes in this PR to get this working. I'll make a few notes throughout.

  • On the homepage (index.qmd) can you switch out using mock.get_mock_model() for using a linear model with mtcars instead?
  • Both on index.qmd and get-started/index.qmd why doesn't anything print out with v.description?
  • The pandas + sklearn code that we use to train the model is too wide for display. Can you add line breaks in a way that makes sense and will look "normal" to Python folks?

get-started/deploy.qmd Outdated Show resolved Hide resolved
get-started/deploy.qmd Outdated Show resolved Hide resolved
get-started/deploy.qmd Outdated Show resolved Hide resolved
contents = open(tmp_docker).read()
print(contents.replace(temp, "."))

```
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should there be a similar note about generating two files here, like the one in the R tab?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No-- it's typical for users have a requirements.txt (or preferred generation method from various tools) already in Python, so the generation of a requirements file is a separate function, load_pkgs. I can add that as a note and re-render!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That would be perfect -- thank you!

index.qmd Outdated Show resolved Hide resolved
@juliasilge juliasilge marked this pull request as ready for review May 11, 2022 22:01
@juliasilge juliasilge merged commit b7217c4 into main May 11, 2022
@juliasilge juliasilge deleted the add-python-sections branch May 11, 2022 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants