Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Dropdown inside Sidenav #1956

Merged
merged 4 commits into from Oct 8, 2021
Merged

Fix Dropdown inside Sidenav #1956

merged 4 commits into from Oct 8, 2021

Conversation

SevenOutman
Copy link
Member

Close #1650

@vercel
Copy link

vercel bot commented Oct 6, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

rsuite-v4 – ./docs

🔍 Inspect: https://vercel.com/rsuite/rsuite-v4/4jqL7UaFnxwnWhRyAXzfrCaTqdBz
✅ Preview: Canceled

[Deployment for 55ed223 canceled]

rsuite – ./

🔍 Inspect: https://vercel.com/rsuite/rsuite/E2nf6QVBXnnWtpc2jJ1QVJcvkXZi
✅ Preview: https://rsuite-git-sevenoutman-issue1650-rsuite.vercel.app

@codesandbox-ci
Copy link

codesandbox-ci bot commented Oct 6, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 55ed223:

Sandbox Source
rsuite-tp-ci Configuration

@codecov
Copy link

codecov bot commented Oct 6, 2021

Codecov Report

Merging #1956 (55ed223) into main (8df455e) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1956      +/-   ##
==========================================
+ Coverage   84.68%   84.71%   +0.02%     
==========================================
  Files         254      254              
  Lines        8040     8040              
  Branches     2179     2178       -1     
==========================================
+ Hits         6809     6811       +2     
  Misses        691      691              
+ Partials      540      538       -2     
Flag Coverage Δ
ChromeCi 84.67% <100.00%> (+0.02%) ⬆️
Firefox 84.70% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/Sidenav/SidenavDropdown.tsx 88.00% <100.00%> (+8.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8df455e...55ed223. Read the comment docs.

Copy link
Member

@simonguo simonguo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'Dropdown' is not defined

应该上一个 PR 中对测试用例的 Dropdown 进行了重命名

@SevenOutman SevenOutman merged commit 07723cd into main Oct 8, 2021
@SevenOutman SevenOutman deleted the SevenOutman/issue1650 branch October 8, 2021 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sidenav dropdown not working
2 participants