Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stdlogctl.c, tester.c don't include <stdarg.h> - don't compile #11

Closed
agordon opened this issue Mar 3, 2014 · 7 comments
Closed

stdlogctl.c, tester.c don't include <stdarg.h> - don't compile #11

agordon opened this issue Mar 3, 2014 · 7 comments

Comments

@agordon
Copy link

@agordon agordon commented Mar 3, 2014

$ make
make  all-recursive
make[1]: Entering directory `/data/gordon/sources/liblogging'
Making all in stdlog
make[2]: Entering directory `/data/gordon/sources/liblogging/stdlog'
  CC       stdlogctl-stdlogctl.o
In file included from stdlogctl.c:32:0:
stdlog.h:80:75: error: unknown type name ‘va_list’
 int stdlog_vlog(stdlog_channel_t ch, const int severity, const char *fmt, va_list ap);
                                                                           ^
In file included from stdlogctl.c:32:0:
stdlog.h:81:131: error: unknown type name ‘va_list’
 int stdlog_vlog_b(stdlog_channel_t ch, const int severity, char *__restrict__ const wrkbuf, const size_t buflen, const char *fmt, va_list ap);
                                                                                                                                   ^
make[2]: *** [stdlogctl-stdlogctl.o] Error 1
make[2]: Leaving directory `/data/gordon/sources/liblogging/stdlog'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/data/gordon/sources/liblogging'
make: *** [all] Error 2

@rgerhards
Copy link
Member

@rgerhards rgerhards commented Mar 3, 2014

Thanks -- which platform is this on?.

@agordon
Copy link
Author

@agordon agordon commented Mar 3, 2014

Ubuntu 10.04

rgerhards added a commit that referenced this issue Mar 3, 2014
closes: #11
Thanks to Assaf Gordon for reporting
@rgerhards
Copy link
Member

@rgerhards rgerhards commented Mar 3, 2014

Thanks again. Above mentioned patch should fix it. Could you give it a try (as I don't have Ubuntu 10.04 right at hand)? If you want, I can email you a new temporary tarball, else you can build from git master branch.

@agordon
Copy link
Author

@agordon agordon commented Mar 3, 2014

That fixed tester.c, but same needs to be fixed in stdlogctl.c .

@rgerhards
Copy link
Member

@rgerhards rgerhards commented Mar 3, 2014

argh... I also finally get it. It's actually a problem with the header files, as these have the va_... types (and need them). Will fix it there...

@rgerhards rgerhards closed this in 3bf42ae Mar 3, 2014
@rgerhards
Copy link
Member

@rgerhards rgerhards commented Mar 3, 2014

The problem had an even higher magnitude, as other apps would also have run into potential build problems. The last commit hopefully fixed that. I'd appreciate if you could report back.

@rgerhards rgerhards reopened this Mar 3, 2014
@agordon
Copy link
Author

@agordon agordon commented Mar 3, 2014

now it compiles cleanly.

@rgerhards rgerhards closed this Mar 12, 2014
Whissi added a commit to Whissi/gentoo-overlay that referenced this issue Apr 14, 2014
v1.0.4 2014-04-03
- fix build problems on some platforms (namely RHEL/CENTOS 5)
- add --disable-man pages ./configure option
  This permits to totally turn off man page handling. This is useful for
  platforms like RHEL/CENTOS 5 where rst2man is hard to get when building
  from git is desired.
- lower build system requirements to autoconf 2.59
  This permits building on RHEL/CENTOs 5 with stock autotools.

v1.0.3 2014-03-18
- fix build problem in Ubuntu 10.04
  Thanks to Assaf Gordon for reporting
  See: rsyslog/liblogging#11
- do not override user varibale CFLAGS
  Thanks to Thomas D. for reporting this problem and suggesting a solution.
  closes: rsyslog/liblogging#15
- make liblogging-rfc3195 not export private symbols
  Thanks to Michael Biebl for his help in getting this right.
- explain that stdlog_log() return code usually most not be checked
  (if same level of reliability like syslog(3) is desired)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants